Skip to content

🇪🇸Add Spanish translation for NativeScript-Vue docs #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Aug 1, 2018
Merged

🇪🇸Add Spanish translation for NativeScript-Vue docs #172

merged 49 commits into from
Aug 1, 2018

Conversation

ianaya89
Copy link
Contributor

@ianaya89 ianaya89 commented Jul 31, 2018

This PR adds translations for the entire doc of NativeScript-Vue.

@nativescript-vue-bot
Copy link

nativescript-vue-bot commented Jul 31, 2018

Deploy preview for nativescript-vue ready!

Built with commit cd547f4

https://deploy-preview-172--nativescript-vue.netlify.com

@rigor789
Copy link
Member

rigor789 commented Aug 1, 2018

Great job! We have recently updated the layout docs, so those may need to be updated, but this is awesome, thank you! :)

@rigor789 rigor789 merged commit e286bb0 into nativescript-vue:master Aug 1, 2018
@ianaya89
Copy link
Contributor Author

ianaya89 commented Aug 1, 2018

@rigor789 thanks. Not sure what has changed and what I need to update

@rigor789
Copy link
Member

rigor789 commented Aug 1, 2018

@ianaya89 here is the PR that changed the layout docs: #164

It has been restructured a little bit, with clearer descriptions of the examples. Heading levels also changed in a few places.

If you could incorporate these changes, that would be amazing!

@ianaya89
Copy link
Contributor Author

ianaya89 commented Aug 1, 2018

@rigor789 Great, let me take a look to the changes and I will submit a PR soon.

BTW, I noticed that some default English text is placed in layouts/partials. I was thinking to add to those layouts/partials multilanguage support. Any ideas or suggestions?

@rigor789
Copy link
Member

rigor789 commented Aug 1, 2018

@ianaya89 Awesome!

And yeah, there are a couple places with English, but there is no way currently to translate them. We may move the site to VuePress (https://vuepress.vuejs.org/) at some point, and then we can tackle that - but for now it's good as is, not a huge problem.

@ianaya89
Copy link
Contributor Author

ianaya89 commented Aug 1, 2018

@rigor789 sounds good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants