[ENH] Adding leaf node samples to be stored when "quantile" tree is turned on #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
scikit-learn#26503) Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
…26566) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…n#25120) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Signed-off-by: Adam Li <adam2392@gmail.com>
|
@sampan501 and @PSSF23 you both might be interested. This is a WIP, but almost done addition of code into the sklearn-fork to enable all trees to optionally store all leaf-node samples. This is useful for:
|
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
PSSF23
reviewed
Jun 16, 2023
There was a problem hiding this comment.
@adam2392 predict_quantiles functions have check_input documentation but the param is not in the function. Meanwhile get_leaf_node_samples has the param but it's not documented. These might cause the errors below:
5 tasks
|
I pushed a commit 3f5cb65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses the quantile-trees part of: neurodata/treeple#29
What does this implement/fix? Explain your changes.
yis (n_samples, n_outputs))Any other comments?