Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove check for valid hostname in test-dns.js #2785

Closed
wants to merge 1 commit into from
Closed

test: remove check for valid hostname in test-dns.js #2785

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 9, 2015

Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468

@Trott Trott added the test Issues and PRs related to the tests. label Sep 9, 2015
@Trott
Copy link
Member Author

Trott commented Sep 9, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/269/

@bnoordhuis
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Sep 9, 2015

Two CI failures appear unrelated. Meanwhile, here's a CI that I've kinda sorta tricked into running the internet tests: https://ci.nodejs.org/job/node-test-commit/534/

The FreeBSD failures are unrelated. (That's a different test that needs to be sorted.) This fixes the test on fedora22 so hooray for that. There is still an issue with Windows, but that's not new and I suspect it's unrelated. Timeout. I'll investigate but I'd love to get this merged first.

@mscdex mscdex added the dns Issues and PRs related to the dns subsystem. label Sep 9, 2015
@Trott
test: remove check for valid hostname in test-dns.js
cd12f23 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: nodejs#2468
@Trott Trott mentioned this pull request Sep 10, 2015
Closed
Trott added a commit that referenced this pull request Sep 10, 2015
@Trott
test: remove valid hostname check in test-dns.js
a1949e8 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468
PR-URL: #2785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott
Copy link
Member Author

Trott commented Sep 10, 2015

Landed in a1949e8

@Trott Trott closed this Sep 10, 2015
Trott added a commit that referenced this pull request Sep 11, 2015
@Trott @rvagg
test: remove valid hostname check in test-dns.js
6e2fe1c 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468
PR-URL: #2785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott added a commit that referenced this pull request Sep 12, 2015
@Trott @rvagg
test: remove valid hostname check in test-dns.js
1dad19b 
Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: #2468
PR-URL: #2785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Sep 12, 2015
Merged
@Trott Trott mentioned this pull request Sep 12, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
Closed
7 tasks
@rvagg rvagg mentioned this pull request Sep 22, 2015
Merged
@Trott Trott deleted the test-dns-hostname-check branch January 9, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @bnoordhuis @mscdex