-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Missingdata - Reorganize nditer implementation into a few files #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks OK. I can confirm this fixes the python3 build. There are some datetime associated test errors in python3, some of which I recall from before, but I think those are unrelated to the current changes so I'll put it in. ERROR: test_datetime_array_str (test_datetime.TestDateTime)Traceback (most recent call last): ERROR: test_datetime_divide (test_datetime.TestDateTime)Traceback (most recent call last): FAIL: test_datetime_as_string (test_datetime.TestDateTime)Traceback (most recent call last): FAIL: test_datetime_as_string_timezone (test_datetime.TestDateTime)Traceback (most recent call last): Ran 3589 tests in 24.787s FAILED (KNOWNFAIL=5, errors=2, failures=2) |
Done. |
Thanks, the string datetime test failures are because the "string" array doesn't return strings in Python 3. I think they should return strings instead of bytes, the current convention is just weird. Will have to bring this up on the list later at some point. |
feat: Add vmla_n_s16
This is primarily a code reorganization pull request, with a few updates to the missing data NEP.