Skip to content

Missingdata - Reorganize nditer implementation into a few files #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

mwiebe
Copy link
Member

@mwiebe mwiebe commented Jul 7, 2011

This is primarily a code reorganization pull request, with a few updates to the missing data NEP.

@charris
Copy link
Member

charris commented Jul 7, 2011

Looks OK. I can confirm this fixes the python3 build. There are some datetime associated test errors in python3, some of which I recall from before, but I think those are unrelated to the current changes so I'll put it in.

ERROR: test_datetime_array_str (test_datetime.TestDateTime)

Traceback (most recent call last):
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/tests/test_datetime.py", line 480, in test_datetime_array_str
assert_equal(str(a), "['2011-03-16' '1920-01-01' '2013-05-19']")
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/numeric.py", line 1380, in array_str
return array2string(a, max_line_width, precision, suppress_small, ' ', "", str)
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/arrayprint.py", line 437, in array2string
separator, prefix, formatter=formatter)
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/arrayprint.py", line 313, in _array2string
_summaryEdgeItems, summary_insert)[:-1]
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/arrayprint.py", line 480, in _formatArray
word = format_function(a[-i]) + separator
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/arrayprint.py", line 726, in call
casting=self.casting)
TypeError: Cannot create a local timezone-based date string from a NumPy datetime without forcing 'unsafe' casting

ERROR: test_datetime_divide (test_datetime.TestDateTime)

Traceback (most recent call last):
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/tests/test_datetime.py", line 896, in test_datetime_divide
assert_equal(tda / tdb, 6.0 / 9.0)
TypeError: internal error: could not find appropriate datetime inner loop in true_divide ufunc

FAIL: test_datetime_as_string (test_datetime.TestDateTime)

Traceback (most recent call last):
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/tests/test_datetime.py", line 1136, in test_datetime_as_string
'1959')
File "/home/charris/.local/lib/python3.2/site-packages/numpy/testing/utils.py", line 313, in assert_equal
raise AssertionError(msg)
AssertionError:
Items are not equal:
ACTUAL: b'1959'
DESIRED: '1959'

FAIL: test_datetime_as_string_timezone (test_datetime.TestDateTime)

Traceback (most recent call last):
File "/home/charris/.local/lib/python3.2/site-packages/numpy/core/tests/test_datetime.py", line 1247, in test_datetime_as_string_timezone
'2010-03-15T06:30Z')
File "/home/charris/.local/lib/python3.2/site-packages/numpy/testing/utils.py", line 313, in assert_equal
raise AssertionError(msg)
AssertionError:
Items are not equal:
ACTUAL: b'2010-03-15T06:30Z'
DESIRED: '2010-03-15T06:30Z'


Ran 3589 tests in 24.787s

FAILED (KNOWNFAIL=5, errors=2, failures=2)

@charris
Copy link
Member

charris commented Jul 7, 2011

Done.

@charris charris closed this Jul 7, 2011
@mwiebe
Copy link
Member Author

mwiebe commented Jul 7, 2011

Thanks, the string datetime test failures are because the "string" array doesn't return strings in Python 3. I think they should return strings instead of bytes, the current convention is just weird. Will have to bring this up on the list later at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants