MAINT: Make assert_array_compare more generic. #11756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy/testing/_private/utils.py
Outdated
| @@ -704,7 +706,7 @@ def func_assert_same_pos(x, y, func=isnan, hasval='nan'): | |||
| # compared usefully, and for which .all() yields masked. | |||
| x_id = func(x) | |||
| y_id = func(y) | |||
| if (x_id == y_id).all() != True: | |||
| if npany(x_id != y_id): | |||
There was a problem hiding this comment.
Would it be overkill to mock up an ndarray subclass for which this succeeds but the previous version fails for a test of the test?
There was a problem hiding this comment.
I thought about it, but didn't want to tie us into that behavior. Could add a comment.
jeffyancey
reviewed
Aug 17, 2018
689d0a3 to
06eb262
Compare
|
@tylerjereddy Added a comment and made the changes more conservative. |
tylerjereddy
approved these changes
Aug 17, 2018
numpy/testing/_private/utils.py
Outdated
| # Both the != True comparison here and the cast to bool_ at the end are | ||
| # done to deal with `masked`, which cannot be compared usefully, and | ||
| # for which np.all yields masked. The use of the function np.all is | ||
| # for backcompatility with ndarray subclasses that changed the return |
There was a problem hiding this comment.
typo -> compatibility
Use np.all instead of the *.all method to be a bit more robust against bad subclasses of ndarray that may change the behavior of the method. Closes numpy#11743.
06eb262 to
78efe63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use np.any instead of method to be a bit more robust against bad
subclassing of ndarray.
Closes #11743.