Skip to content

MAINT: Make assert_array_compare more generic. #11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

charris
Copy link
Member

@charris charris commented Aug 17, 2018

Backport of #11756

Use np.all instead of the *.all method to be a bit more robust against
bad subclasses of ndarray that may change the behavior of the method.

Closes #11756.

Use np.all instead of the *.all method to be a bit more robust against
bad subclasses of ndarray that may change the behavior of the method.

Closes numpy#11743.
Copy link
Contributor

@jeffyancey jeffyancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@charris charris merged commit d1c5cf7 into numpy:maintenance/1.15.x Aug 18, 2018
@charris charris deleted the fix-testing-utils branch August 18, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants