MAINT: Move umath error helpers into their own module #13322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9028b99 to
896b7be
Compare
eric-wieser
commented
Apr 13, 2019
| @@ -4415,7 +4415,7 @@ | |||
| Examples | |||
| -------- | |||
| >>> np.geterrobj() # first get the defaults | |||
| [10000, 0, None] | |||
| [8192, 521, None] | |||
There was a problem hiding this comment.
This documentation was incorrect, and caused by the doctests running before circular imports resolved (!?)
This is a direct move, with some tweaks to imports. For some reason, this changed the results of running the doctests, which now reflect the actual defaults for `geterrobj`. This helps to make `core.numeric` a little shorter. This doesn't affect the value of `np.core.numeric.__all__` which keeps code doing `from numpy.core.numeric import *` working.
896b7be to
b87a9e2
Compare
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct move, with some tweaks to imports
This works towards breaking cyclic imports through
core/numeric.py, and makes that file a little bit shorter.This doesn't affect the value of
np.core.numeric.__all__which keeps code doingfrom numpy.core.numeric import *working.Inspired by some of the ideas in #11924