MAINT: Use exec() instead array_function_dispatch to improve tracebacks #13529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xref numpyGH-12028 Current behavior: >>> np.dot(None, None) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/shoyer/dev/numpy/numpy/core/overrides.py", line 175, in public_api implementation, public_api, relevant_args, args, kwargs) TypeError: unsupported operand type(s) for *: 'NoneType' and 'NoneType' >>> np.stack([], invalid=True) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/shoyer/dev/numpy/numpy/core/overrides.py", line 148, in public_api relevant_args = dispatcher(*args, **kwargs) TypeError: _stack_dispatcher() got an unexpected keyword argument 'invalid' With this change: >>> np.dot(None, None) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "<string>", line 6, in dot TypeError: unsupported operand type(s) for *: 'NoneType' and 'NoneType' >>> np.stack([], invalid=True) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "<string>", line 4, in stack TypeError: _stack_dispatcher() got an unexpected keyword argument 'invalid'
|
Would be good to include your timing info in this PR for the sake of archaeology in future. |
|
|
eric-wieser
approved these changes
May 11, 2019
|
Thanks Stephan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref GH-12028
Current behavior:
With this change:
This fixes an issue pointed out by @mattip