DOC: revert __skip_array_function__ from NEP-18 #13624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts most of the changes from numpyGH-13305, and adds a brief discussion of ``__skip_array_function__`` into the "Alternatives" section. We still use NumPy's implementation of the function internally inside ``ndarray.__array_function__``, but I've given it a new name in the NEP (``_implementation``) to indicate that it's a private API.
mhvk
approved these changes
May 25, 2019
|
I added a note about temporary support for opting out with |
shoyer
added a commit
to shoyer/numpy
that referenced
this pull request
May 25, 2019
xref numpyGH-13624, numpyGH-12028 TODO: update tests/CI for NUMPY_EXPERIMENTAL_ARRAY_FUNCTION=0
|
See #13627 for corresponding code updates. |
|
Let's get this in. We can make further changes if needed as things develop. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #12028
This reverts most of the changes from GH-13305, and adds a brief discussion of
__skip_array_function__into the "Alternatives" section.We still use NumPy's implementation of the function internally inside
ndarray.__array_function__, but I've given it a new name in the NEP (_implementation) to indicate that it's a private API.