-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
MAINT: remove the entropy c-extension module #14498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't think this should be called a deprecation, since exposing the new module in 1.17.0 was an oversight in the first place. Hopefully gh-14360 will prevent these kind of issues in the future. |
I noticed that too, always needs an extra commit after opening PR, pretty odd.
agreed. I'd be in favor of backporting this to 1.17.x |
the CircleCI failure is related |
@charris okay to backport this to 1.17.x? I think that'd be helpful, to not have a documented public-looking function in the latest 1.17.x release. |
@rgommers I'm OK with that. I'd like to get all the fixes and changes to the new random module into 1.17. This is our shaking out period. |
Replace
entropy
withSeedSequence
and remove the module.xref gh-14359
release note needed, but cannot create until the PR is opened