Skip to content

MAINT: remove the entropy c-extension module #14498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2019

Conversation

mattip
Copy link
Member

@mattip mattip commented Sep 13, 2019

Replace entropy with SeedSequence and remove the module.

xref gh-14359

release note needed, but cannot create until the PR is opened

@mattip
Copy link
Member Author

mattip commented Sep 13, 2019

I don't think this should be called a deprecation, since exposing the new module in 1.17.0 was an oversight in the first place. Hopefully gh-14360 will prevent these kind of issues in the future.

@rgommers
Copy link
Member

release note needed, but cannot create until the PR is opened

I noticed that too, always needs an extra commit after opening PR, pretty odd.

I don't think this should be called a deprecation, since exposing the new module in 1.17.0 was an oversight in the first place.

agreed. I'd be in favor of backporting this to 1.17.x

@rgommers
Copy link
Member

the CircleCI failure is related

@rgommers
Copy link
Member

LGTM, and since @bashtage approved of removing this in gh-14359 I'll push the green button. Thanks @mattip

@rgommers rgommers merged commit 33d5f9c into numpy:master Sep 15, 2019
@rgommers
Copy link
Member

@charris okay to backport this to 1.17.x? I think that'd be helpful, to not have a documented public-looking function in the latest 1.17.x release.

@charris
Copy link
Member

charris commented Sep 15, 2019

@rgommers I'm OK with that. I'd like to get all the fixes and changes to the new random module into 1.17. This is our shaking out period.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Sep 15, 2019
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Sep 22, 2019
@charris charris removed this from the 1.17.3 release milestone Sep 22, 2019
@mattip mattip deleted the random-namespace branch June 8, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants