Skip to content

BUILD: pin pygments to 2.6.1, 2.7.0 breaks custom NumPyC lexer #17304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

mattip
Copy link
Member

@mattip mattip commented Sep 13, 2020

Try to figure out what is going on with circleCI and doc building. Maybe time to move to githbu actions?

@mattip mattip force-pushed the circleci branch 2 times, most recently from af3ac03 to 0b93d6f Compare September 13, 2020 19:57
@mattip
Copy link
Member Author

mattip commented Sep 13, 2020

I have no idea why this build is failing. It worked, then broke but only on CircleCI.

Edit: By that I mean it works on three different machines I tried ...

@mattip
Copy link
Member Author

mattip commented Sep 14, 2020

closes gh-17301

@mattip mattip changed the title WIP, BUILD: start to debug circleCI failures BUILD: pin pygments to 2.6.1, 2.7.0 breaks custom NumPyC lexer Sep 14, 2020
@mattip
Copy link
Member Author

mattip commented Sep 14, 2020

It turns out the problem was an unpinned dependency on pygments. They updated the CLexer in the recent 2.7.0 release, which broke a hack to the lexer tokens. While strictly speaking only the changes to doc_requirements.txt are needed to fix gh-17301, I think the other changes are worthwhile.

A follow-on PR will fix the lexer, this PR is needed to unbreak the doc builds.

@charris
Copy link
Member

charris commented Sep 14, 2020

Thanks for chasing that down. I'm not going to wait on travisCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants