Skip to content

DOC: improve issubdtype and scalar type docs #17330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

@eric-wieser
Copy link
Member Author

Not sure why github is linking to the wrong CircleCI build, the real one is https://app.circleci.com/pipelines/github/numpy/numpy/3679/workflows/bbd2257f-2d41-4cb9-882a-48511446daa7/jobs/15768

@seberg
Copy link
Member

seberg commented Sep 16, 2020

@larsoner a ping about the build artifact link. It seems it is sometimes broken (such as here), although it is possible that this only happens when circle CI gives an error.

@eric-wieser
Copy link
Member Author

eric-wieser commented Sep 16, 2020

@seberg: In this case even the first-party CircleCI link is broken and points to the wrong build (of a commit that does not exist)

@seberg
Copy link
Member

seberg commented Sep 16, 2020

Oh, OK, then maybe that type of thing caused it to fail somewhere. It was just a single PR where I had noticed a mismatch, thought it was repeating now.

@larsoner
Copy link
Contributor

There can be problems when the fork and upstream both have CircleCI enabled:

scientific-python/circleci-artifacts-redirector-action#7

But indeed these builds are just failing themselves

@rgommers
Copy link
Member

The improved issubdtype docstring with examples looks much better, thanks @eric-wieser

`types.BooleanType` and similar names were python2 things that no longer exist

`unicode` also no longer exists, and is now `str`
@mattip
Copy link
Member

mattip commented Sep 16, 2020

This needs the fix in gh-17304 to pin pygments version

@eric-wieser
Copy link
Member Author

Will rebase on master if this needs any other changes - otherwise I'd be inclined to merge as is rather than starting another CI run.

@seberg
Copy link
Member

seberg commented Sep 17, 2020

The artifact for the "See also" link seems correct and the rest also seems fine and is definitely an improvement, so I will just put this in (there are also no warnings beyond the gh-17304 one). Thanks.

@seberg seberg merged commit bde2119 into numpy:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants