DOC: Fix incorrect .. deprecated:: syntax that led to this note being invisible
#17329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seberg, I'm confused by this comment now, having found the commit that authored it. Was the intent for it to say something more like "TODO: consider deprecating?" |
a46435d to
b97c21c
Compare
|
No its deprecated, the parent commit is the one that adds it, this just removed it again for unrecognized types to go to object. So |
|
So this message was supposed to be visible in the docs? |
|
Yes, it was supposed to be visible, so this change seems good. |
|
I pushed to the wrong branch by accident and triggered a bogus CircleCI build, but the original build is at |
|
Actually, I've generally just made a mess of my history here, the first commit is #17330. Let's deal with this one after that goes in. |
.. deprecated:: syntax that led to this note being invisible.. deprecated:: syntax that led to this note being invisible
.. deprecated:: syntax that led to this note being invisible.. deprecated:: syntax that led to this note being invisible
|
Rebased, and warning looks fine in the artifact. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in cefd352