DEV: Fix shell configuration in devcontainer #23076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable, so lets get it in, thanks. @jungaretti do you think we could set this up to use |
I looked at this, but upgrading to |
|
Follow-up in gh-23411 - using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our repo setup to
onCreateCommandfrompostCreateCommandin order to resolve a race condition betweenconda initand the default shell in VS Code. You can test this newdevcontainer.jsonby creating a codespace for my fork/branch: https://github.com/codespaces/new?hide_repo_select=true&ref=jungaretti%2Fupdate-devcontainer&repo=576410652postCreateCommanddoesn't block interaction with your codespace. You can use other terminals and move around editors while it runs. On the other hand,onCreateCommandruns before you interact with your codespace. You won't be able to open a terminal until it finishes.onCreateCommandis a better choice for running our setup script because we need to runconda initbefore using the terminal.