-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
BUG: Handle .pyf.src and fix SciPy [urgent] #25287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test failures are because of compute limits. EDIT: |
Will finalize this tomorrow. |
This reverts commit 9240eba.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylerjereddy if this works for you as well I'd suggest it might be worthwhile to merge this now.
Ok, I skimmed through the diff and confirmed that SciPy main
testsuite is back to "normal" (other unrelated issues) with this NumPy branch on M2 Mac, so seems fixed to me.
I'm obviously not an f2py
expert, but there's some suggestion we should try to get this in and it does unbreak SciPy with some more regression tests.
I'll merge it, normally I squash backport candidates for SciPy to make backporting easier; however, maybe Chuck will forgive me for not squashing in this case given that some commits are distinct vendoring commits and so on, and it can also be helpful if we need to bisect again (hopefully not, but...). |
I plan to do worse, once f2py settles a bit I'm going to straight copy it down into 1.26.x. I'd usually let things ride, but 2.0 isn't going to come out this month. I some point I distutils might break in 1.26, but meson builds seem to be stabilizing downstream. |
Thanks for the quick fix!
Please don't try this. I on purpose did not do that, not only because the |
Closes gh-25286. We don't have tests for
.pyf.src
files, which can be added in a follow up. It would also be nice forf2py
to provide thefrom_template
functionality instead of forcinggenerate_f2pymod.py
inscipy
to vendor it fromdistutils
.@tylerjereddy if this works for you as well I'd suggest it might be worthwhile to merge this now.
@charris this will need to be backported.
A lot of these are very annoyingly tiny bugs, but each one slowly inches
f2py
towards a better testsuite (among other things).This PR:
.pyf
files#defines
Also:
.src
file handlingdistutils
behavior w.r.t. compiled extension modulesTests:
scipy
builds locally