Skip to content

BUG: Handle .pyf.src and fix SciPy [urgent] #25482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 24, 2023

Conversation

charris
Copy link
Member

@charris charris commented Dec 23, 2023

Backport of #25287.

Closes gh-25286. We don't have tests for .pyf.src files, which can be added in a follow up. It would also be nice for f2py to provide the from_template functionality instead of forcing generate_f2pymod.py in scipy to vendor it from distutils.

@tylerjereddy if this works for you as well I'd suggest it might be worthwhile to merge this now.

@charris this will need to be backported.

A lot of these are very annoyingly tiny bugs, but each one slowly inches f2py towards a better testsuite (among other things).

This PR:

  • Don't lower .pyf files
  • Stop making useless untitled modules
  • Fix some of the #defines

Also:

  • Vendors the .src file handling
  • Re-establishes old distutils behavior w.r.t. compiled extension modules
    • Basically overwrites them

Tests:

@charris charris merged commit 502737f into numpy:maintenance/1.26.x Dec 24, 2023
@charris charris deleted the backport-25287 branch December 24, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants