Skip to content

BLD: unpin cibuildwheel [wheel build] #25503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

mattip
Copy link
Member

@mattip mattip commented Dec 27, 2023

PyPy has a new release, so we should be able to update cibuildwheel to the latest 2.16.2 2.16.4 version

cc @charris

@github-actions github-actions bot added the 36 - Build Build related PR label Dec 27, 2023
@charris
Copy link
Member

charris commented Dec 27, 2023

I think we need to wait for the next cibuildwheel release, otherwise pinning would not have worked.

@charris
Copy link
Member

charris commented Dec 27, 2023

I pinged the cibuildwheel folks at pypa/cibuildwheel#1642.

@mattip
Copy link
Member Author

mattip commented Dec 27, 2023

The failure is in using the openblas_support.py script. I wonder if using the openblas wheels instead to get the shared object as we do in CI (not a full runtime dependency on the wheel) would work around the PyPy bug. That is on my TODO list, I guess it is time to do it.

@mattip
Copy link
Member Author

mattip commented Jan 27, 2024

cibuildwheel 2.16.3 was released with an updated pypy 7.3.14, which fixes one bug but adds another. So this PR should wait for an even newer cibuildwheel release. See pypa/cibuildwheel#1736

@mattip
Copy link
Member Author

mattip commented Jan 27, 2024

hmm. It seems something is off with wheel building on macos:

_multiarray_umath.cpython-39-darwin.so, 0x0002): symbol not found in flat namespace (_cblas_caxpy64_)

, probably due to bumping the OpenBLAS version in #25687, which changed how the tarball is created.

@mattip mattip force-pushed the unpin-cibuildwheel branch from fbe4004 to ffb5ac3 Compare January 27, 2024 21:55
@mattip
Copy link
Member Author

mattip commented Jan 27, 2024

Great. Now there is a pytest failure. Apparently applying a mark to a fixture

@pytest.mark.slow
@pytest.mark.skipif(NO_MYPY, reason="Mypy is not installed")
@pytest.fixture(scope="module", autouse=True)
def run_mypy() -> None:

now emits a deprecation warning on pytest>=7.4 so collection is failing. This is due to the release of pytest 8.0 a few hours ago.

@mattip mattip force-pushed the unpin-cibuildwheel branch from ffb5ac3 to b2f895d Compare January 29, 2024 12:06
@mattip
Copy link
Member Author

mattip commented Jan 29, 2024

Rebased off main to get #25710, and updated to cibuildwheel 2.16.4 (latest version, released yesterday).

@mattip
Copy link
Member Author

mattip commented Jan 29, 2024

There is a problem with the newer OpenBLAS tarballs on macos. I am working on it in MacPython/openblas-libs#130, it might take a few hours to resolve.

@mattip
Copy link
Member Author

mattip commented Jan 29, 2024

Darn. I fixed one problem, but there is now a problem when using delocate

  ERROR:delocate.libsana:
  /usr/local/lib/libscipy_openblas64_.0.dylib not found

I guess there is still some hints of the older shared objects burned into the single libscipy_openblas64_.dylib (without the .0)

@mattip
Copy link
Member Author

mattip commented Jan 29, 2024

Working on this in MacPython/openblas-libs#131

@mattip
Copy link
Member Author

mattip commented Jan 30, 2024

I reran the failing tests after fixing the macos shared object name, and reran the failing ci steps. Now the wheel action passed but the UI here does not reflect the success.

@mattip
Copy link
Member Author

mattip commented Jan 30, 2024

Ahh, no, it is the cirrus actions that need rerunning. The github ones show success.

@mattip
Copy link
Member Author

mattip commented Jan 30, 2024

I retriggered the failed cirrus runs, let's see in ~40 minutes

@mattip
Copy link
Member Author

mattip commented Jan 30, 2024

Ci is passing.

@charris charris merged commit 2a52c57 into numpy:main Jan 30, 2024
@charris
Copy link
Member

charris commented Jan 30, 2024

Thanks Matti.

@mattip mattip deleted the unpin-cibuildwheel branch May 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants