-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
BLD: unpin cibuildwheel [wheel build] #25503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we need to wait for the next cibuildwheel release, otherwise pinning would not have worked. |
I pinged the cibuildwheel folks at pypa/cibuildwheel#1642. |
The failure is in using the |
cibuildwheel 2.16.3 was released with an updated pypy 7.3.14, which fixes one bug but adds another. So this PR should wait for an even newer cibuildwheel release. See pypa/cibuildwheel#1736 |
hmm. It seems something is off with wheel building on macos:
, probably due to bumping the OpenBLAS version in #25687, which changed how the tarball is created. |
fbe4004
to
ffb5ac3
Compare
Great. Now there is a pytest failure. Apparently applying a mark to a fixture numpy/numpy/typing/tests/test_typing.py Lines 75 to 78 in 1df5ad9
now emits a deprecation warning on pytest>=7.4 so collection is failing. This is due to the release of pytest 8.0 a few hours ago. |
ffb5ac3
to
b2f895d
Compare
Rebased off main to get #25710, and updated to cibuildwheel 2.16.4 (latest version, released yesterday). |
There is a problem with the newer OpenBLAS tarballs on macos. I am working on it in MacPython/openblas-libs#130, it might take a few hours to resolve. |
Darn. I fixed one problem, but there is now a problem when using delocate
I guess there is still some hints of the older shared objects burned into the single |
Working on this in MacPython/openblas-libs#131 |
I reran the failing tests after fixing the macos shared object name, and reran the failing ci steps. Now the wheel action passed but the UI here does not reflect the success. |
Ahh, no, it is the cirrus actions that need rerunning. The github ones show success. |
I retriggered the failed cirrus runs, let's see in ~40 minutes |
Ci is passing. |
Thanks Matti. |
PyPy has a new release, so we should be able to update cibuildwheel to the latest
2.16.22.16.4 versioncc @charris