Skip to content

DOC: update and copy-edit 2.0.0 release notes #25921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Mar 3, 2024

The complete copy-edit was a lot of work, so I left it at that and didn't try to also reorder sections or add highlights or other narrative content in this PR.

@rgommers rgommers added this to the 2.0.0 release milestone Mar 3, 2024
@rgommers rgommers requested a review from charris March 3, 2024 22:38
rgommers added 3 commits March 4, 2024 09:23
The page was almost completely unreadable before, and the level 3
section headers were a random grab bag of topics. Now it's down
to version numbers and links to the main sections (Improvements,
Pull requests merged, etc.).
Fixes textual and formatting issues, adds missing section headers,
groups some entries that belonged together in one section, etc.

[skip actions] [skip cirrus] [skip azp]
@mattip
Copy link
Member

mattip commented Mar 4, 2024

LGTM, it seems like all of the info has been transfered. This can be improved in subsequent PRs.

@mattip mattip merged commit 0fd60a2 into numpy:main Mar 4, 2024
@mattip
Copy link
Member

mattip commented Mar 4, 2024

Thanks @rgommers

@rgommers rgommers deleted the 2.0.0-relnotes branch March 4, 2024 10:33
@mattip
Copy link
Member

mattip commented Mar 4, 2024

I forgot to check that the release notes actually appear. They are not appearing in the rendered documents. Is towncrier deleting them?

@mattip
Copy link
Member

mattip commented Mar 4, 2024

Ahh, we can add a .. towncrier release notes start which will cause a header duplication but will not remove the existing content. See the previous iteration of this problem in these comments

@rgommers
Copy link
Member Author

rgommers commented Mar 4, 2024

Ah yes, will take that along in the next PR.

@rgommers
Copy link
Member Author

rgommers commented Mar 4, 2024

Except it doesn't work. And when working around that, it seems there is no way to tell it to not stage things for committing (except for adding --draft and manually piping that into a new file). Will try a bit more and hook it into spin docs somehow, but this isn't quite general-purpose tooling.

rgommers added a commit to rgommers/numpy that referenced this pull request Mar 4, 2024
This allows accumulating snippets into the main release notes file and
committing the result during a release cycle. It will also make Sphinx
formatting errors, cross-link issues, etc. visible when docs get built
locally. This will allow fixing them as we go, rather than leaving it
broken in devdocs and then having to fix it in one go once `towncrier`
is run once right before or after creating a release branch.

xref numpygh-25921 and numpygh-25827 for recent issues with this.

[skip azp] [skip actions] [skip cirrus]
rgommers added a commit to rgommers/numpy that referenced this pull request Mar 5, 2024
This allows accumulating snippets into the main release notes file and
committing the result during a release cycle. It will also make Sphinx
formatting errors, cross-link issues, etc. visible when docs get built
locally. This will allow fixing them as we go, rather than leaving it
broken in devdocs and then having to fix it in one go once `towncrier`
is run once right before or after creating a release branch.

xref numpygh-25921 and numpygh-25827 for recent issues with this.

[skip azp] [skip actions] [skip cirrus]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants