-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
DOC: 2.0 release highlights and compat notes changes #25937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let me ping a few people for specific categories:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance section looks good to me. Just some minor edits, if it seems appropriate.
As asked for in numpygh-25610 [skip actions] [skip azp] [skip cirrus]
For many users, running `ruff` may be all they need to do - or it's very helpful at least - so don't hide it at the end of this very long page.
[skip actions] [skip azp] [skip cirrus]
here is the rendered document, if that is easier for people to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is ready for review yet, but here's a first round.
Please sneak this snippet in, it was left out of #25914:
cc @asmeurer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how, so fine. One thing that I wonder about is that e.g. NEP 50 and the Python removals is what users will actually care about most in terms of compatibility and in terms of being the largest changes and improvements in many ways.
I would be happy to iterate, thus the thought of adding a note.
Sure, putting that under |
[skip actions] [skip azp] [skip cirrus]
Thanks, accepted all suggestions that are resolved. |
As expected, #25943 causes pandas import to fail, which fails the docs build. |
Can confirm, yes; just regular maintenance to reflect the runtime changes. |
close/reopen |
Close/reopen to get latest dev wheels |
Maybe we should skip the doctest tests for now, until a pandas fix for the dtype is merged and new nightly wheels are uploaded? |
Instead of skipping doctests, we could move them later in the CI steps, which AFAICT would still upload artifacts, see #25962 |
I had the same thought. We use next to nothing from pandas, so it's a little annoying that our doc builds are blocked on it. However, if we break pandas we usually also break matplotlib, so in those cases it won't help. |
Right, in general it won't help. But for this PR specifically it will: #25962, which was merged to HEAD, does upload artifacts. So rebasing this off |
Thanks! Will rebase after the next update - which should make this merge-able (EDIT: not just yet). |
[skip actions] [skip azp] [skip cirrus]
The rendered doc is here. There some warnings it would be nice to clean up if possible
|
[skip azp] [skip actions] [skip cirrus]
We really have to get to zero warnings and turn on the "error on warning" behavior in CI. I'd say that at least 75% of all PRs that add release notes are introducing new issues. |
[skip actions] [skip azp] [skip cirrus]
I think this is good to go now. It deserves another large copy-edit of the full notes, but that can be done in a few weeks time. This should be good enough for 2.0.0b1. |
here are the rendered docs. |
I am not sure how to review this, so I will just put it in as-is. Anyway it will not successfully be displayed as the devdocs until the pandas doctest passes and the build is un-broken. It is evident a lot of work went into this, thanks to all who contributed. There are some formatting glitches: some items are lists and some are topics, it would be nice to try to straighten that out for the next version. |
Thanks @rgommers |
Thanks!
Would it be easy to work around? I am slightly worried that the next in line is matplotlib and that might not be quite as quick. |
Is that in progress / do they need help? I haven't had problems yet with local doc builds, so I think the damage should be limited. I'm babysitting the SciPy nightlies now, they will hopefully be up within the next hour. |
I think a PR to skip the doctest tests and then another to revert it would work, we would merge the second one once it passes. |
OK, cool, for me it is just an unknown for whether they might hit pybind11 issues mainly (I doubt it from my first look, but hard to be sure). Let's just see, maybe this is all very quick, if not we can still rearrange the upload. |
I'm not worried about the failing doc tests, just ignore them. They don't block the wheel releases and the 2.0.0 release is about a month away, which is when we need to generate the docs. |
This is a draft of the narrative section of the 2.0.0 release notes, with highlights and main messages. I think it needs to be significantly longer than that of a normal feature release, and give the reader an overview of what's in this release as well as links to other key documentation like the migration guide and the page about packaging for downstream libraries.
For the highlights I chose six top-level categories and then 2-4 items for each of those categories. Which are:
A lot of work has gone into this release, so I'm sure this isn't 100% complete or representative yet. A few questions to promt feedback on this draft:
This PR also takes care of some leftover tasks for release notes and migration guide.