Skip to content

CI: fix error in pyodide CI #26166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ngoldbaum
Copy link
Member

Fixes #26164.

@ngoldbaum
Copy link
Member Author

Ah, the virtual environment gets populated after numpy is built. Not immediately clear to me what the correct thing to do is, I'll leave this to @agriyakhetarpal.

@ngoldbaum ngoldbaum closed this Mar 29, 2024
@agriyakhetarpal
Copy link
Contributor

agriyakhetarpal commented Mar 29, 2024

Thanks for tagging me!

(I think) we'll need to add a patch for the Pyodide installation to make it use build<1.2 inside the virtual environment, so, yes, pinning the Emscripten requirements would not have worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: emscripten pyiodide build failing
2 participants