-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
CI: emscripten pyiodide build failing #26164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@hoodmane Any ideas as to the problem? |
Copying the traceback for searchability:
This is a generic problem; the same failure is visible on the PyWavelets repo. @agriyakhetarpal would you be able to investigate this issue? |
Thanks, @rgommers – I indeed noticed this and I was going to open an issue today here, someone else got towards doing it first :) I'm happy to investigate further. |
I cannot say for sure, but most likely it's coming from the |
Sounds good, and sounds like the right diagnosis. Let's add the upper bound first to unbreak things, and then investigate further? |
It looks like |
I'll make a note about this on the Pyodide issue tracker too. Maybe keeping |
I have tried a few things, and the |
This should be fixed by pyodide/pyodide#4653. I guess pinning |
Thank you for the quick fix, @hoodmane and @ryanking13! I'll patch those changes in when it gets merged. |
To be clear, it was just @ryanking13 I am just reporting what he did =) |
Yes, I think we should make a backport release as this will break everywhere. Until that, please pin the build version to < 1.2.0. |
Pyodide 0.25.1 is out, a preliminary PR is at #26185. @agriyakhetarpal I needed to disable the patching, both chunks were failing to apply. Not sure what changed. |
Uh oh!
There was an error while loading. Please reload this page.
See https://github.com/numpy/numpy/actions/runs/8473585481/job/23218246517?pr=26160. I was suspicious the setup-python upgrade may have been responsible, but reverting does not fix the failures.
The text was updated successfully, but these errors were encountered: