MAINT: Move ndarray.__str__ and ndarray.__repr__ to their own file #9202
Conversation
| * Set the array print function to be a Python function. | ||
| */ | ||
| NPY_NO_EXPORT void | ||
| PyArray_SetStringFunction(PyObject *op, int repr) |
There was a problem hiding this comment.
Seems that this isn't being picked up by the tool to build the numpy API
There was a problem hiding this comment.
You need to add things in numpy/core/setup.py -- multiarray_deps
There was a problem hiding this comment.
Nope, help still needed - it still doesn't build for that reason
There was a problem hiding this comment.
(That fixup was some other errors that I spotted that would appear once I fix this API one)
There was a problem hiding this comment.
Solved - API_FILES in getapi.py
There was a problem hiding this comment.
the _deps listings should be unnecessary now, nothing actually reads them and for gcc compatible compilers it determines dependencies automatically.
There was a problem hiding this comment.
Wish these things were documented a bit more clearly... Raised issue gh-9203 to remind us.
a4ae553 to
1bc3688
Compare
1bc3688 to
7de5027
Compare
7de5027 to
04da564
Compare
|
All set, builds locally now |
04da564 to
b961c3c
Compare
|
This looks all OK now. Hopefully the tests will bear this out... |
|
Tests are good! |
|
OK, even though this hasn't been out long enough for it to be necessarily noticed by all, I think this is a clear enough improvement that I'll just merge it. Then, #9201 can proceed as well. |
Goal here is to let the definition for
__unicode__be in the same place too (#9201).This doesn't build, claiming there's a mismatch between the API dict and index.What have I done wrong?