-
Notifications
You must be signed in to change notification settings - Fork 766
Add Weaviate Instrumentation Structure #3646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Weaviate Instrumentation Structure #3646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: run tox -e generate again
61c157d
to
afce36f
Compare
Co-authored-by: Pablo Collins <pablo.collins@gmail.com>
afce36f
to
2bb71cd
Compare
Nir Gazit approved using v2 for this instrumentation like the langchain instrumentation. See slack conversation here: https://cloud-native.slack.com/archives/C06KR7ARS3X/p1753460962522759 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few more places that need updating, please see #3600 as a template. eachdist.ini
and one more place in RELEASING.md
at least.
Apologies for all the boilerplate.
* Initial structure * Update scripts/generate_instrumentation_bootstrap.py Co-authored-by: Pablo Collins <pablo.collins@gmail.com> * missing generated library * Version update to offset traceloop implementation * uv sync after rebase * Missing release entries --------- Co-authored-by: Pablo Collins <pablo.collins@gmail.com>
Description
This PR creates the basic structure of adding instrumentation to weaviate-client. Currently, Traceloop/OpenLLMetry has a weaviate client package, but it is limited to spans only, doesn't include metrics and events, and doesn't support some of the incubating semantic conventions
This PR places the structure of the weaviate-client instrumentation, with implementation to follow.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A - instrumentation is not included in this PR
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.