Skip to content

Conversation

keith-decker
Copy link
Contributor

Description

This PR creates the basic structure of adding instrumentation to weaviate-client. Currently, Traceloop/OpenLLMetry has a weaviate client package, but it is limited to spans only, doesn't include metrics and events, and doesn't support some of the incubating semantic conventions

This PR places the structure of the weaviate-client instrumentation, with implementation to follow.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

N/A - instrumentation is not included in this PR

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@keith-decker keith-decker requested a review from a team as a code owner July 21, 2025 16:27
Copy link

linux-foundation-easycla bot commented Jul 21, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: run tox -e generate again

@keith-decker keith-decker force-pushed the instrumentation-weaviate-base branch from 61c157d to afce36f Compare July 29, 2025 14:47
@keith-decker keith-decker force-pushed the instrumentation-weaviate-base branch from afce36f to 2bb71cd Compare July 29, 2025 15:07
@keith-decker
Copy link
Contributor Author

Nir Gazit approved using v2 for this instrumentation like the langchain instrumentation. See slack conversation here: https://cloud-native.slack.com/archives/C06KR7ARS3X/p1753460962522759

@keith-decker keith-decker requested a review from emdneto July 29, 2025 17:54
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few more places that need updating, please see #3600 as a template. eachdist.ini and one more place in RELEASING.md at least.

Apologies for all the boilerplate.

@keith-decker
Copy link
Contributor Author

There's a few more places that need updating, please see #3600 as a template. eachdist.ini and one more place in RELEASING.md at least.

Apologies for all the boilerplate.

@aabmass Fixed!

@aabmass aabmass merged commit 74536f1 into open-telemetry:main Aug 4, 2025
625 checks passed
@liustve liustve mentioned this pull request Aug 5, 2025
7 tasks
devmonkey22 pushed a commit to devmonkey22/opentelemetry-python-contrib that referenced this pull request Aug 5, 2025
* Initial structure

* Update scripts/generate_instrumentation_bootstrap.py

Co-authored-by: Pablo Collins <pablo.collins@gmail.com>

* missing generated library

* Version update to offset traceloop implementation

* uv sync after rebase

* Missing release entries

---------

Co-authored-by: Pablo Collins <pablo.collins@gmail.com>
@aabmass aabmass mentioned this pull request Aug 13, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants