tests: improve coverage for timeouts and retries with async cases #2596
+451
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi OpenAI team 👋 This PR extends the test coverage for timeouts and retries: Adds async tests for per-request timeouts overriding client defaults. Covers the case where smaller per-request timeouts trigger TimeoutException. Expands retries tests for Retry-After handling, server errors, and max retries exceeded. All changes are backward-compatible (tests only). Please let me know if you'd like me to adjust the structure, naming, or add more scenarios. Happy to iterate based on your feedback! Thanks for reviewing 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sertions
What
Why
The previous test suite covered only basic sync cases. This change ensures:
How
tests/test_timeouts_async.pywith detailed assertions on timeout extraction.tests/test_retries.pywith more scenarios for retry handling.httpx.MockTransportto simulate API responses deterministically.Result
All timeout/retry logic is now covered by both sync and async tests, increasing confidence and preventing regressions.