Skip to content

Conversation

james-elicx
Copy link
Collaborator

  • Uses the Prettier config that we have in cloudflare adapter
  • Adds an action to run in pipelines

@james-elicx james-elicx force-pushed the james/add-prettier branch 4 times, most recently from 9b5315c to f5c1285 Compare February 25, 2025 21:04
@james-elicx james-elicx marked this pull request as ready for review February 25, 2025 21:07
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's something I was desperately missing!
Thanks for taking the time to implement this.

Let's wait for aws approval before merging.

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for doing that.
We may want to ask netlify as well

@vicb
Copy link
Contributor

vicb commented Feb 26, 2025

We may want to ask netlify as well

^ @serhalp ?

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a question about bun

"lint": "next lint",
"prettier:check": "prettier --check .",
"prettier:fix": "prettier --write .",
"fix": "bun run prettier:fix"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? I don't see bun being used anywhere else, and it isn't installed in local dev (just CI) 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo uses Bun - there's a bun.lockb for managing deps in here. Looking at it, we have both a bun.lockb and package-lock.json, but the ci has always used bun

@james-elicx james-elicx merged commit 9cd75ea into main Feb 26, 2025
1 check passed
@james-elicx james-elicx deleted the james/add-prettier branch February 26, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants