-
Notifications
You must be signed in to change notification settings - Fork 39
chore: add formatter #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
james-elicx
commented
Feb 25, 2025
- Uses the Prettier config that we have in cloudflare adapter
- Adds an action to run in pipelines
9b5315c
to
f5c1285
Compare
f5c1285
to
b15bebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something I was desperately missing!
Thanks for taking the time to implement this.
Let's wait for aws approval before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for doing that.
We may want to ask netlify as well
^ @serhalp ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just a question about bun
"lint": "next lint", | ||
"prettier:check": "prettier --check .", | ||
"prettier:fix": "prettier --write .", | ||
"fix": "bun run prettier:fix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? I don't see bun being used anywhere else, and it isn't installed in local dev (just CI) 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo uses Bun - there's a bun.lockb for managing deps in here. Looking at it, we have both a bun.lockb and package-lock.json, but the ci has always used bun