Skip to content

chore: put default demo in demos/default #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 24, 2021
Merged

chore: put default demo in demos/default #836

merged 5 commits into from
Nov 24, 2021

Conversation

tiffafoo
Copy link

@tiffafoo tiffafoo commented Nov 24, 2021 •
edited
Loading

Summary

  • Move the default demo site: /demo => /demos/default (to allow multiple demo sites)
  • Fix broken cypress test

Build settings have been updated to work with this pr

Test plan

  1. Visit deploy preview and see all is ok: https://619e32e2c1cae5402f223739--netlify-plugin-nextjs-demo.netlify.app/fr/
  2. Visit deploy logs and see all is ok: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/619e32e2c1cae5402f223739

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

#839

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@tiffafoo tiffafoo added the type: chore work needed to keep the product and development running smoothly label Nov 24, 2021
@tiffafoo tiffafoo requested a review from ascorbic November 24, 2021 12:48
@tiffafoo tiffafoo marked this pull request as ready for review November 24, 2021 12:48
ascorbic
ascorbic approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kodiakhq kodiakhq bot merged commit 38fdd62 into main Nov 24, 2021
@kodiakhq kodiakhq bot deleted the tln/demos branch November 24, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ascorbic ascorbic ascorbic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiffafoo @ascorbic