Skip to content

chore: add nx demo #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 30, 2021
Merged

chore: add nx demo #854

merged 12 commits into from
Nov 30, 2021

Conversation

tiffafoo
Copy link

@tiffafoo tiffafoo commented Nov 29, 2021

Summary

Adds an nx demo site and cypress config specific to it

Test plan

  1. Visit the Deploy Preview: https://deploy-preview-854--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/
  2. Check logs and see it is running the cypress config for nx: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61a60ef6e913a116996cad14

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

#839

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Nov 29, 2021
@netlify
Copy link

netlify bot commented Nov 30, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo canceled.

🔨 Explore the source changes: 56d0638

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61a641e9fdfd8f0007821a23

@tiffafoo tiffafoo requested a review from ascorbic November 30, 2021 11:51
@tiffafoo tiffafoo marked this pull request as ready for review November 30, 2021 11:51
it('loads home page', () => {
cy.findByRole('heading', { name: 'Welcome to nx-nextjs-monorepo!' })

cy.visit('//')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why //?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to test that trailing slashes work as expected (aka default removes it)

@kodiakhq kodiakhq bot merged commit 6c167f3 into main Nov 30, 2021
@kodiakhq kodiakhq bot deleted the tln/add-nx branch November 30, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants