fix(chart): [chart] Fixed chart-core bug #1706

Davont · 2024-06-28T09:38:58Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Bug Fixes
- Updated map service URLs and API keys from Google Maps to Amap and Baidu Maps for improved accuracy and performance.
- Enhanced object cloning in chart-core to use cloneDeep for better reliability.
- Improved getFormatted function to handle null values more effectively.
Chores
- Updated version number from "3.17.0" to "3.17.1" in package.json.

coderabbitai · 2024-06-28T09:39:04Z

Walkthrough

Overall, the changes primarily involve updates to comments and configurations concerning map services, ensuring correct API references for Amap and Baidu Maps instead of Google Maps. Additionally, an improvement was made in the chart-core.ts to enhance cloning functionality using cloneDeep, and a minor bug fix was applied in util.ts to handle null values effectively. Lastly, there was a version increment in the package.json file for @opentiny/vue-chart-core.

Changes

File Path	Change Summary
`examples/sites/demos/pc/app/chart/amap/base-composition-api.vue`, `examples/sites/demos/pc/app/chart/amap/base.vue`	Updated comments to correctly reference "高德地图" (Amap) instead of "谷歌地图" (Google Maps).
`examples/sites/demos/pc/app/chart/bmap/base.vue`	Changed API key and URL for map services from Google Maps to Baidu Maps.
`packages/vue/src/chart/chart-core/src/chart-core.ts`	Replaced JSON cloning with `cloneDeep` for better object cloning.
`packages/vue/src/chart/chart-core/common/util.ts`	Modified `getFormatted` function to include a null check condition.
`packages/vue/src/chart/chart-core/package.json`	Updated version number from "3.17.0" to "3.17.1".

Poem

Amidst the code lines, a rabbit hops,
Fixing maps' trails with gentle stops.
Autonavi and Baidu, now shine bright,
Cloning perfected, with all might.
Null checks in place, errors no more,
Version ticks up, we all soar! 🚀🐇

Tip

Early access features: enabled

We are currently testing the following features in early access:

OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
Please join our Discord Community to provide feedback and report issues.
OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

packages/vue/src/chart/chart-core/src/chart-core.ts (1)
Line range hint 248-252: Refactor to Use Optional Chaining

The static analysis has identified several places where optional chaining could be used to make the code cleaner and safer by automatically handling undefined or null values.
- if (this.afterConfig) {
+ if (this.afterConfig?) {
    option = this.afterConfig(option)
  }
...
- if (this.extend && Object.keys(this.extend).length !== 0) {
+ if (this.extend?.length !== 0) {
    option.extend = this.applyExtend(this.integrateChart.eChartOption)
  }
...
Also applies to: 295-298, 492-492, 497-500, 538-540, 540-543, 548-548

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4a863b9 and 85fc901.

Files selected for processing (4)

examples/sites/demos/pc/app/chart/amap/base-composition-api.vue (1 hunks)
examples/sites/demos/pc/app/chart/amap/base.vue (1 hunks)
examples/sites/demos/pc/app/chart/bmap/base.vue (1 hunks)
packages/vue/src/chart/chart-core/src/chart-core.ts (3 hunks)

Files skipped from review due to trivial changes (2)

examples/sites/demos/pc/app/chart/amap/base-composition-api.vue
examples/sites/demos/pc/app/chart/amap/base.vue

Additional context used

Gitleaks

examples/sites/demos/pc/app/chart/bmap/base.vue

17-17: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

Biome

packages/vue/src/chart/chart-core/src/chart-core.ts

[error] 248-252: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 295-298: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 492-492: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 497-500: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 538-540: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 540-543: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

[error] 548-548: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Additional comments not posted (3)

examples/sites/demos/pc/app/chart/bmap/base.vue (1)

18-18: Updated API URL

The URL has been correctly updated to point to Baidu Maps. Ensure that all related services are compatible with Baidu Maps to avoid integration issues.

packages/vue/src/chart/chart-core/src/chart-core.ts (2)

8-8: Imported cloneDeep for Better Cloning

The introduction of cloneDeep from lodash ensures a more reliable and error-free deep cloning compared to the previous methods (JSON.parse(JSON.stringify()) and spread operator). This change will likely improve the robustness of data handling within the chart components.

344-344: Refactoring to Use cloneDeep

Refactoring the cloning method to use cloneDeep is a good practice as it avoids the pitfalls of the previous shallow copy methods which might not correctly handle nested objects or special JavaScript objects like Date, RegExp, etc.

Also applies to: 531-531

examples/sites/demos/pc/app/chart/bmap/base.vue

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 85fc901 and 38227ec.

Files selected for processing (1)

packages/vue/src/chart/chart-core/common/util.ts (1 hunks)

Additional context used

Biome

packages/vue/src/chart/chart-core/common/util.ts

[error] 20-20: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

[error] 32-32: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

Additional comments not posted (1)

packages/vue/src/chart/chart-core/common/util.ts (1)

17-17: Enhance robustness by checking for null values.

The added check for null values enhances the robustness of the function.

packages/vue/src/chart/chart-core/common/util.ts

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 38227ec and 16bf480.

Files selected for processing (1)

packages/vue/src/chart/chart-core/package.json (1 hunks)

Files skipped from review due to trivial changes (1)

packages/vue/src/chart/chart-core/package.json

* fix(chart): [chart] Fixed chart-core bug (#1706) * fix: 【Charts】update charts snapshots * fix: 修复图表height为100%时的高度问题 * fix: 优化图表extend逻辑 * fix: 修复图表extend失效问题 * fix: 删除注释 * fix: 新增图表echartOption变量，以便用户获取echart配置 * fix: 修复playground百度地图案例错误问题 * fix: 修复图表option复杂变量失效问题 * fix: 修改高德百度地图案例注释 * fix: chart-core添加cloneDeep引入 * fix: 修改chart组件getFormatted函数判断逻辑 * fix: 更新chart-core包版本为3.17.1 * chore: release-3.17.0 to dev (#1720) * fix(card): 修复card组件样式污染全局问题 * feat(drawer): [drawer] Add drag listening event (#1701) * feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number * feat(vue): [button-group] add empty slot (#1700) * feat(vue): [button-group] add empty slot * docs(button-group): add new api version * fix(select): fix Select‘s SMB theme, multi select svg color (#1705) * feat: update theme version * fix(popper): fix build error in vitepress (#1711) * fix(popper): fix build error in vitepress * fix(popper): 升级版本 * fix(select): rename select's css var name (#1713) --------- Co-authored-by: zzcr <894103554@qq.com> Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> * chore(fluent-editor): update package.json (#1721) * feat: add virtual-scroll component * feat(WIP):Add virtual-scroll component content * feat(virtual-scroll):add virtual-scroll componet message * Delete .vscode/tasks.json * feat(virtual-scroll):add virtual-scroll basic component * chore:delete unless cord * chore:delete unless code * chore:delete unless core * chore:delete unless code * chore:delete unless code * chore:delete unless code * chore:delete unless code * chore:delete unless code * fix(virtual-scroll):modify virtual scrolling problem * chore:delete unless code * chore:delete unless code * feat(virtual-scroll):Add horizontal scrolling function * feat(virtual-scroll):Added dynamic height function * chore:Modify dynamic height bug --------- Co-authored-by: Davont <davontz@icloud.com> Co-authored-by: Kagol <kagol@sina.com> Co-authored-by: zzcr <894103554@qq.com> Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com>

Davont added 13 commits May 20, 2024 04:08

fix: 【Charts】update charts snapshots

12ed2e5

Merge branch 'dev' of github.com:opentiny/tiny-vue into dev

049e055

fix: 修复图表height为100%时的高度问题

e002b99

fix: 优化图表extend逻辑

94a15eb

Merge branch 'dev' of github.com:opentiny/tiny-vue into dev

c411a5e

fix: 修复图表extend失效问题

fe1d231

fix: 删除注释

8fdc5c5

fix: 新增图表echartOption变量，以便用户获取echart配置

7e4e830

fix: 修复playground百度地图案例错误问题

19052b2

fix: 修复图表option复杂变量失效问题

9c98733

fix: 修改高德百度地图案例注释

256dae7

Merge branch 'dev' into dev

c77eac6

fix: chart-core添加cloneDeep引入

85fc901

coderabbitai bot reviewed Jun 28, 2024

View reviewed changes

examples/sites/demos/pc/app/chart/bmap/base.vue Outdated Show resolved Hide resolved

Davont added 2 commits July 1, 2024 05:26

Merge branch 'dev' of github.com:opentiny/tiny-vue into dev

613c9e7

fix: 修改chart组件getFormatted函数判断逻辑

38227ec

coderabbitai bot reviewed Jul 1, 2024

View reviewed changes

packages/vue/src/chart/chart-core/common/util.ts Show resolved Hide resolved

zzcr reviewed Jul 2, 2024

View reviewed changes

packages/vue/src/chart/chart-core/common/util.ts Show resolved Hide resolved

fix: 更新chart-core包版本为3.17.1

16bf480

coderabbitai bot reviewed Jul 2, 2024

View reviewed changes

zzcr approved these changes Jul 2, 2024

View reviewed changes

zzcr merged commit a2b3c6a into opentiny:dev Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(chart): [chart] Fixed chart-core bug #1706

fix(chart): [chart] Fixed chart-core bug #1706

Uh oh!

Davont commented Jun 28, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 28, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

fix(chart): [chart] Fixed chart-core bug #1706

fix(chart): [chart] Fixed chart-core bug #1706

Uh oh!

Conversation

Davont commented Jun 28, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Davont commented Jun 28, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 28, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)