fix(select): fix Select‘s SMB theme, multi select svg color #1705

shenjunjian · 2024-06-28T08:59:15Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Updated various UI elements with new colors and hover behaviors for a more polished visual appearance.
- Enhanced styles for multi-select SVG icons in dropdown selectors.
New Features
- Added variables for customizing colors and borders of multi-select SVG icons to improve theme flexibility.

coderabbitai · 2024-06-28T08:59:27Z

Warning

Review failed

The pull request is closed.

Walkthrough

Recent updates to the theme package primarily enhance the visual styling and user experience for UI elements such as checkboxes, SVG icons, and text. Changes involve modifying CSS selectors, adjusting fill colors, hover behaviors, and updating themes to ensure consistency and improved aesthetics.

Changes

Files	Change Summary
`.../option/index.less`	Updated CSS selectors with new classes and adjusted fill colors and hover effects for SVG icons.
`.../option/smb-theme.js`	Adjusted colors and styles for checkbox borders, selected backgrounds, and text colors for better user experience.
`.../option/vars.less`	Added new variables for customizing colors and borders of multi-select SVG icons.

Poem

In a meadow of code where colors align,
CSS and themes in a wondrous design. 🌈
With checkboxes bright and SVGs anew,
The interface refreshed, for both old and new.
Hovering light with a soft, gentle hue,
Our code now sparkles like morning dew.
Enjoy the new theme, from a rabbit to you! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-06-28T08:59:52Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

* fix(card): 修复card组件样式污染全局问题 * feat(drawer): [drawer] Add drag listening event (#1701) * feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number * feat(vue): [button-group] add empty slot (#1700) * feat(vue): [button-group] add empty slot * docs(button-group): add new api version * fix(select): fix Select‘s SMB theme, multi select svg color (#1705) * feat: update theme version * fix(popper): fix build error in vitepress (#1711) * fix(popper): fix build error in vitepress * fix(popper): 升级版本 * fix(select): rename select's css var name (#1713) --------- Co-authored-by: zzcr <894103554@qq.com> Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com>

* fix(card): 修复card组件样式污染全局问题 * feat(drawer): [drawer] Add drag listening event (#1701) * feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number * feat(vue): [button-group] add empty slot (#1700) * feat(vue): [button-group] add empty slot * docs(button-group): add new api version * fix(select): fix Select‘s SMB theme, multi select svg color (#1705) * feat: update theme version * fix(chart): [chart] Fixed chart-core bug (#1708) * fix: chart-core添加cloneDeep引入 * fix: 修改chart组件getFormatted函数判断逻辑 * fix: 更新chart-core包版本为3.17.1 * fix(popper): fix build error in vitepress (#1711) * fix(popper): fix build error in vitepress * fix(popper): 升级版本 * fix(select): rename select's css var name (#1713) * fix(grid): [grid] change custom components to tinyvue components to a… (#1724) * fix(grid): [grid] change custom components to tinyvue components to adapt difference theme * Update package.json * fix(drawer): fix the issue content can not display when using v-if (#1733) * fix(dropdown): fix dropdown in virtual scrolling grid (#1717) * feat: update renderless version * fix(select): the input parameter of the computedDisabledTooltipcontent lost props (#1740) * fix(select): the input parameter of the computedDisabledTooltipcontent does not contain props * fix(select): update version * fix(grid-toolbar): [grid] fix toolbar ref name error (#1745) --------- Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> Co-authored-by: Davont <davontz@icloud.com> Co-authored-by: Huang Yilin <huangyilin16@qq.com>

* fix(card): 修复card组件样式污染全局问题 * feat(drawer): [drawer] Add drag listening event (#1701) * feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number * feat(vue): [button-group] add empty slot (#1700) * feat(vue): [button-group] add empty slot * docs(button-group): add new api version * fix(select): fix Select‘s SMB theme, multi select svg color (#1705) * feat: update theme version * fix(chart): [chart] Fixed chart-core bug (#1708) * fix: chart-core添加cloneDeep引入 * fix: 修改chart组件getFormatted函数判断逻辑 * fix: 更新chart-core包版本为3.17.1 * fix(popper): fix build error in vitepress (#1711) * fix(popper): fix build error in vitepress * fix(popper): 升级版本 * fix(select): rename select's css var name (#1713) * fix(grid): [grid] change custom components to tinyvue components to a… (#1724) * fix(grid): [grid] change custom components to tinyvue components to adapt difference theme * Update package.json * fix(drawer): fix the issue content can not display when using v-if (#1733) * fix(dropdown): fix dropdown in virtual scrolling grid (#1717) * feat: update renderless version * fix(select): the input parameter of the computedDisabledTooltipcontent lost props (#1740) * fix(select): the input parameter of the computedDisabledTooltipcontent does not contain props * fix(select): update version * fix(grid-toolbar): [grid] fix toolbar ref name error (#1745) * fix(breadcrumb): [breadcrumb] resolve delimiter issued (#1755) * fix(breadcrumb): [breadcrumb] resolve delimiter issued * fix(breadcrumb): [breadcrumb] resolve delimiter issued * feat: update runtime version * fix(breadcrumb): [breadcrumb] resolve the issue of separator not switching (#1783) * fix(theme): when release theme, copy dist to _dist and replace cssvar… (#1768) * fix(theme): when release theme, copy dist to _dist and replace cssvar's prefix name * fix(vue-theme): update package's version --------- Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> Co-authored-by: Davont <davontz@icloud.com> Co-authored-by: Huang Yilin <huangyilin16@qq.com> Co-authored-by: wuyiping0628 <42107997+wuyiping0628@users.noreply.github.com>

* fix(chart): [chart] Fixed chart-core bug (#1706) * fix: 【Charts】update charts snapshots * fix: 修复图表height为100%时的高度问题 * fix: 优化图表extend逻辑 * fix: 修复图表extend失效问题 * fix: 删除注释 * fix: 新增图表echartOption变量，以便用户获取echart配置 * fix: 修复playground百度地图案例错误问题 * fix: 修复图表option复杂变量失效问题 * fix: 修改高德百度地图案例注释 * fix: chart-core添加cloneDeep引入 * fix: 修改chart组件getFormatted函数判断逻辑 * fix: 更新chart-core包版本为3.17.1 * chore: release-3.17.0 to dev (#1720) * fix(card): 修复card组件样式污染全局问题 * feat(drawer): [drawer] Add drag listening event (#1701) * feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number * feat(vue): [button-group] add empty slot (#1700) * feat(vue): [button-group] add empty slot * docs(button-group): add new api version * fix(select): fix Select‘s SMB theme, multi select svg color (#1705) * feat: update theme version * fix(popper): fix build error in vitepress (#1711) * fix(popper): fix build error in vitepress * fix(popper): 升级版本 * fix(select): rename select's css var name (#1713) --------- Co-authored-by: zzcr <894103554@qq.com> Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> * chore(fluent-editor): update package.json (#1721) * feat: add virtual-scroll component * feat(WIP):Add virtual-scroll component content * feat(virtual-scroll):add virtual-scroll componet message * Delete .vscode/tasks.json * feat(virtual-scroll):add virtual-scroll basic component * chore:delete unless cord * chore:delete unless code * chore:delete unless core * chore:delete unless code * chore:delete unless code * chore:delete unless code * chore:delete unless code * chore:delete unless code * fix(virtual-scroll):modify virtual scrolling problem * chore:delete unless code * chore:delete unless code * feat(virtual-scroll):Add horizontal scrolling function * feat(virtual-scroll):Added dynamic height function * chore:Modify dynamic height bug --------- Co-authored-by: Davont <davontz@icloud.com> Co-authored-by: Kagol <kagol@sina.com> Co-authored-by: zzcr <894103554@qq.com> Co-authored-by: MomoPoppy <125256456+MomoPoppy@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com>

fix(select): fix Select‘s SMB theme, multi select svg color

7ac05d1

shenjunjian added the bug Something isn't working label Jun 28, 2024

zzcr approved these changes Jun 28, 2024

View reviewed changes

zzcr merged commit d9d47ba into opentiny:release-3.17.0 Jun 28, 2024

kagol pushed a commit that referenced this pull request Jul 5, 2024

fix(select): fix Select‘s SMB theme, multi select svg color (#1705)

6e69698

kagol pushed a commit that referenced this pull request Aug 7, 2024

fix(select): fix Select‘s SMB theme, multi select svg color (#1705)

9944951

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(select): fix Select‘s SMB theme, multi select svg color #1705

fix(select): fix Select‘s SMB theme, multi select svg color #1705

Uh oh!

shenjunjian commented Jun 28, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 28, 2024 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 28, 2024

Uh oh!

Uh oh!

fix(select): fix Select‘s SMB theme, multi select svg color #1705

fix(select): fix Select‘s SMB theme, multi select svg color #1705

Uh oh!

Conversation

shenjunjian commented Jun 28, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 28, 2024

Uh oh!

Uh oh!

shenjunjian commented Jun 28, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 28, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)