[FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Reference Include="System.Xml.Linq" /> | ||
| <Reference Include="System.Data.DataSetExtensions" /> | ||
| <Reference Include="System.Data" /> | ||
| <Reference Include="System.Xml" /> |
There was a problem hiding this comment.
why so many references are added.
There was a problem hiding this comment.
These were added automatically when I updated the package. Additional dependency of Namotion.Reflection was added automatically and it is now a required dependency.
msohailhussain
suggested changes
Feb 24, 2023
Great catch. I did not know about .nuspec reqs. Still much to learn. Thanks Sohail & Noman |
|
@mikechu-optimizely when do you think this will get released? |
|
@nuttytree, We have a major new feature releasing soon which will of course include this edit to NuGet. Let me put an agenda item on today's stand up meeting to discuss. |
mnoman09
added a commit
that referenced
this pull request
Mar 10, 2023
mikechu-optimizely
pushed a commit
that referenced
this pull request
Mar 15, 2023
…ersion (#330) * Updated newtonsoft.Json version and NjsonSchema version * fix * reverting endline * updated to latest * Updated version in nuspec * Reverting unneseccary dependency * Namotion.reflection is required dependency after update --------- Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com> Co-authored-by: Mike Chu <104384559+mikechu-optimizely@users.noreply.github.com> (cherry picked from commit 503c7d8)
mnoman09
added a commit
that referenced
this pull request
Mar 16, 2023
mnoman09
added a commit
that referenced
this pull request
Mar 16, 2023
* chore : updated prefix of ticket-check action (#314) (cherry picked from commit 678c6fd) * chore: Fix and Reconfigure GitHub Actions (#319) * Fix <return> method doc for IsFeatureEnabled (#329) * [FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version (#330) * [FSSDK-8955] Refac: Replaced all instances of full stack except from changelog file and code files (#331) * Replaced all instances of full stack except from changelog file and code files Co-authored-by: Griffin Cox <104227910+griffincox-optimizely@users.noreply.github.com> * [FSSDK-8955] Do not lint markdown for now * [FSSDK-8955] Remove VALIDATE_MARKDOWN --------- Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com> Co-authored-by: Griffin Cox <104227910+griffincox-optimizely@users.noreply.github.com> Co-authored-by: Mike Chu <michael.chu@optimizely.com> (cherry picked from commit 5f16357) (cherry picked from commit 887166e) * [FSSDK-8955] Refac: Replaced all instances of full stack from code comments and in nuspec except owner. (#332) (cherry picked from commit 2a5b19c) * [FSSDK-8955] chore: prepare for release 3.11.2 (#333) * [FSSDK-8955] chore: prepare for release 3.11.2 * Nit fixed --------- Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com> (cherry picked from commit e620c08) * updated release date to 16th March --------- Co-authored-by: Muhammad Shaharyar <shairy333@gmail.com> Co-authored-by: Mike Chu <104384559+mikechu-optimizely@users.noreply.github.com> Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All tests should pass.
Issues