Skip to content

Fixing the git action build ubuntu to 18.04 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 23, 2022
Merged

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jun 8, 2022

Summary

  • with ubuntu latest tests were failing without any particular reason and no fix was working so as we were testing on travis using ubuntu trusty so we just changed the ubuntu version to fix 18.04 to avoid further issues

Test plan

all tests should pass

@mnoman09 mnoman09 changed the title test Fixing the git action build ubuntu to 18.04 Jun 23, 2022
@msohailhussain msohailhussain marked this pull request as ready for review June 23, 2022 18:09
@msohailhussain msohailhussain requested a review from a team as a code owner June 23, 2022 18:09
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 60188c6 into master Jun 23, 2022
@msohailhussain msohailhussain deleted the mnoman/testBuilds branch June 23, 2022 19:04
jaeopt pushed a commit that referenced this pull request Mar 13, 2023
* test

* test

* test

* adding travis yml to make sure everytest is working

* test

* test

* commenting out gitaction build for now until github action resolves there issue

* enabling only unit test for testing

* test

* test

* test

* test

* test again

* test

* test

* test

* test

* changed ubuntu version to 18.04 from latest

* removing travis yml

* reverted the changes

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants