Skip to content

Fixing the git action build ubuntu to 18.04 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 23, 2022
Merged

Fixing the git action build ubuntu to 18.04 #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
97beb3a
test
mnoman09 Jun 8, 2022
c3d0004
test
mnoman09 Jun 8, 2022
38be57a
test
mnoman09 Jun 8, 2022
c48fa8a
adding travis yml to make sure everytest is working
mnoman09 Jun 8, 2022
1099c56
test
mnoman09 Jun 8, 2022
6aac5df
test
mnoman09 Jun 8, 2022
04368f0
commenting out gitaction build for now until github action resolves t…
mnoman09 Jun 8, 2022
b001535
enabling only unit test for testing
mnoman09 Jun 22, 2022
c4fc1ae
test
mnoman09 Jun 23, 2022
c182bab
test
mnoman09 Jun 23, 2022
76ef644
test
mnoman09 Jun 23, 2022
fc967a5
test
mnoman09 Jun 23, 2022
44b005b
test again
mnoman09 Jun 23, 2022
de01fad
test
mnoman09 Jun 23, 2022
1224790
test
mnoman09 Jun 23, 2022
8a131e4
test
mnoman09 Jun 23, 2022
f8cd561
test
mnoman09 Jun 23, 2022
3d0a01d
changed ubuntu version to 18.04 from latest
mnoman09 Jun 23, 2022
d39d529
removing travis yml
mnoman09 Jun 23, 2022
4626cf7
reverted the changes
mnoman09 Jun 23, 2022
8c5dec9
revert
mnoman09 Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
required: true
jobs:
run_build:
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- name: set up JDK 8
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

name: Java CI with Gradle

on:
Expand Down Expand Up @@ -46,7 +45,7 @@ jobs:

test:
if: startsWith(github.ref, 'refs/tags/') != true
runs-on: ubuntu-latest
runs-on: ubuntu-18.04
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -82,12 +81,12 @@ jobs:
./gradlew exhaustiveTest
./gradlew build
- name: Check on failures
if: steps.unit_tests.outcome != 'success'
if: always() && steps.unit_tests.outcome != 'success'
run: |
cat /home/runner/java-sdk/core-api/build/reports/findbugs/main.html
cat /home/runner/java-sdk/core-api/build/reports/findbugs/test.html
- name: Check on success
if: steps.unit_tests.outcome == 'success'
if: always() && steps.unit_tests.outcome == 'success'
run: |
./gradlew coveralls uploadArchives --console plain

Expand Down
2 changes: 1 addition & 1 deletion core-api/src/test/java/com/optimizely/ab/config/DatafileProjectConfigTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ private static void verifyExperiments(List<Experiment> actual, List<Experiment>
assertThat(actualExperiment.getGroupId(), is(expectedExperiment.getGroupId()));
assertThat(actualExperiment.getStatus(), is(expectedExperiment.getStatus()));
assertThat(actualExperiment.getAudienceIds(), is(expectedExperiment.getAudienceIds()));
assertThat(actualExperiment.getAudienceConditions(), is(expectedExperiment.getAudienceConditions()));
assertEquals(actualExperiment.getAudienceConditions(), expectedExperiment.getAudienceConditions());
assertThat(actualExperiment.getUserIdToVariationKeyMap(),
is(expectedExperiment.getUserIdToVariationKeyMap()));

Expand Down
1 change: 1 addition & 0 deletions core-api/src/test/java/com/optimizely/ab/config/parser/JacksonConfigParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public void parseProjectConfigV3() throws Exception {
verifyProjectConfig(actual, expected);
}

@SuppressFBWarnings("NP_NULL_PARAM_DEREF")
@Test
public void parseProjectConfigV4() throws Exception {
JacksonConfigParser parser = new JacksonConfigParser();
Expand Down