Skip to content

Updating evaluation of rollout rules #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 29, 2017
Merged

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

@alda-optimizely
Copy link
Contributor

lgtm..barf!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.509% when pulling 07b8692 on arizvi/update_rollout into b76340c on master.

Copy link
Contributor

@alda-optimizely alda-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.509% when pulling c3dbfa9 on arizvi/update_rollout into b76340c on master.

@aliabbasrizvi aliabbasrizvi merged commit 669bca2 into master Aug 29, 2017
@aliabbasrizvi aliabbasrizvi deleted the arizvi/update_rollout branch August 29, 2017 05:49
Returns the variation of the first experiment the user qualifies for.

Args:
layer: Layer for which we are getting the variation.
rollout: Rollout for which we are getting the variation.
user_id: ID for user.
attributes: Dict representing user attributes.
ignore_user_profile: True to ignore the user profile lookup. Defaults to False.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, just realized, this is no longer needed because we don't call get_variation. You can safely remove it to avoid confusion!

aliabbasrizvi added a commit that referenced this pull request Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants