feat(eventProcessor): Incorporate batch processing into OptimizelyFactory. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Sep 5, 2019
mjc1283
approved these changes
Sep 9, 2019
msohailhussain
suggested changes
Sep 9, 2019
lib/optimizely/optimizely_factory.rb
Outdated
| unless batch_size.is_a? Integer | ||
| logger.log( | ||
| Logger::ERROR, | ||
| 'Batch size has invalid type. Reverting to default configuration.' |
There was a problem hiding this comment.
Please change this message to
Batch size is invalid, setting to default batch size {batchSize}
lib/optimizely/optimizely_factory.rb
Outdated
| unless batch_size.positive? | ||
| logger.log( | ||
| Logger::ERROR, | ||
| 'Batch size cannot be <= 0. Reverting to default configuration.' |
There was a problem hiding this comment.
Batch size is negative, setting to default batch size {batchSize}
lib/optimizely/optimizely_factory.rb
Outdated
| unless flush_interval.is_a? Numeric | ||
| logger.log( | ||
| Logger::ERROR, | ||
| 'Flush interval has invalid type. Reverting to default configuration.' |
There was a problem hiding this comment.
please change these msgs too.
lib/optimizely/optimizely_factory.rb
Outdated
| unless flush_interval.positive? | ||
| logger.log( | ||
| Logger::ERROR, | ||
| 'Flush interval cannot be <= 0. Reverting to default configuration.' |
There was a problem hiding this comment.
this one as well. @oakbani
| @@ -57,6 +105,13 @@ def self.custom_instance( | |||
| config_manager = nil, | |||
| notification_center = nil | |||
| ) | |||
| event_processor = BatchEventProcessor.new( | |||
There was a problem hiding this comment.
Can you please add in a doc, default batchsize and flush_interval will be used to setup batchEventProcessor.
|
@msohailhussain Could you please review the updates from @rashidsp ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BatchEventProcessorwithOptimizelyFactory.Test plan