Skip to content

TST: Testing for mixed int/str Index #61349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 83 commits into
base: main
Choose a base branch
from
Open

TST: Testing for mixed int/str Index #61349

wants to merge 83 commits into from
+186 −66

Conversation

xaris96
Copy link

@xaris96 xaris96 commented Apr 24, 2025 •
edited
Loading

pelagiavlas and others added 26 commits March 26, 2025 22:58
@pelagiavlas
Added requirements.txt with project dependencies
29039f9
@pelagiavlas
ValueError in pytest parametrization due to direct Index object evalu…
65de448 
…ation
@pelagiavlas
BUG: Fix TypeError in set operations with mixed int/string indexes
0816a26
@pelagiavlas
BUG: Handle mixed int/str types in Index.union
b87036f
@pelagiavlas
BUG: Fix value_counts() with mixed int/str indexes containing nulls
946f99b
@xaris96
Merge branch 'main' of https://github.com/pandas-dev/pandas
a671eb7
@xaris96
Merge branch 'main' of https://github.com/pandas-dev/pandas
416a6ae
@pelagiavlas
BUG: Ignore mixed-type comparison warning in tests
2e63667
@pelagiavlas
BUG: Apply xfail to handle unsupported int/str comparison in test_sor…
5550b1d 
…t_values_invalid_na_position
@pelagiavlas
BUG: Apply xfail to handle unsupported int/str comparison in test_sor…
33e2a34 
…t_values_with_missing
@pelagiavlas
BUG: Mark test_numpy_ufuncs_reductions as xfail for mixed int/str index
d7b534e
@pelagiavlas
BUG: Avoid mixed-type Index in argsort test to prevent sorting errors
642734e
@pelagiavlas
BUG: Skip argsort tests for mixed-type Index to avoid TypeError
dea15de
@pelagiavlas
TST: Add skip for tests using mixed-type Index
03c3b0a
@xaris96
one new test just for the mixed string in indices_dict (pandas\confet…
5d1c154 
…s.py)
@xaris96
log files
c10c263
@xaris96
fixed test_union_duplicates[mixed-int-string] test fail in tests\inde…
edb84e4 
…xes\multi\test_setops.py
@xaris96
2 test passed for mixed int string
af140a8
@xaris96
test_union_same_type mixed int string
8992100
@xaris96
test_union_different_types mixed int string fixed
1fe92f9
@xaris96
test_union_base mixed int string test fail fixed
599df6d
@xaris96
total 5 tests fixed and 2 made xfailed
3256953
@xaris96
Merge branch 'issue-TM' into vol2
bf05b29
@xaris96
all tests passed!
c856799
@xaris96
merged
ed90c56
@xaris96
changes
e3f1eb2
@datapythonista
Copy link
Member

@xaris96 Can you fix the broken tests and remove all your debug files from this PR please?

@datapythonista datapythonista added Testing pandas testing functions or related to the test suite Index Related to the Index class or subclasses labels May 3, 2025
@datapythonista datapythonista changed the title Issue tm TST: Testing for mixed int/str Index May 3, 2025
xaris96 and others added 5 commits May 22, 2025 19:30
@xaris96 @mroeschke
Update doc/source/whatsnew/v3.0.0.rst
a61324a 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@xaris96 @mroeschke
Update pandas/tests/base/test_misc.py
0d6ea71 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@xaris96 @mroeschke
Update pandas/tests/base/test_misc.py
105352a 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@xaris96 @mroeschke
Update pandas/tests/base/test_misc.py
2ad71a5 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@xaris96
comments fixed
acfec32
@xaris96 xaris96 requested a review from mroeschke May 23, 2025 07:30
mroeschke
mroeschke reviewed May 23, 2025
View reviewed changes
mroeschke
mroeschke requested changes May 23, 2025
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the diff and consistently use these following conventions

  1. Use inferred_type to check for the new mixed-int-string case you added
  2. If a test fails, do not astype or pytest.skip. Add an pytest.mark.xfail to the test instead

@xaris96 xaris96 force-pushed the issue-TM branch 6 times, most recently from 92e9e10 to a1eed56 Compare May 30, 2025 15:40
@xaris96 xaris96 requested a review from Dr-Irv as a code owner May 30, 2025 15:40
@xaris96 xaris96 requested a review from mroeschke June 2, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach Awaiting requested review from rhshadrach

@Dr-Irv Dr-Irv Awaiting requested review from Dr-Irv

@mroeschke mroeschke Awaiting requested review from mroeschke

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TST: mixed_int_string Index
5 participants
@xaris96 @datapythonista @jbrockmendel @mroeschke @pelagiavlas