TST: Testing for mixed int/str Index #61349
Open
+188
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_values_invalid_na_position
…t_values_with_missing
…xes\multi\test_setops.py
|
@xaris96 Can you fix the broken tests and remove all your debug files from this PR please? |
mroeschke
reviewed
May 22, 2025
mroeschke
reviewed
May 22, 2025
mroeschke
reviewed
May 22, 2025
mroeschke
reviewed
May 22, 2025
mroeschke
reviewed
May 22, 2025
mroeschke
requested changes
May 22, 2025
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
reviewed
May 23, 2025
mroeschke
requested changes
May 23, 2025
Comment on lines
+158
to
+160
| has_str = any(isinstance(x, str) for x in index) | ||
| has_int = any(isinstance(x, int) for x in index) | ||
| if has_str and has_int: |
There was a problem hiding this comment.
I tried using .inferred_type, but it causes unrelated tests to fail (not just the mixed int/str ones). Let me know if you'd like more details.
Comment on lines
+66
to
+69
| @pytest.mark.parametrize( | ||
| "index_or_series_obj", [[1, 2, 3], ["a", "b", "c"], [0, "a", 1, "b", 2, "c"]] | ||
| ) | ||
| @pytest.mark.parametrize("sort", [True, False]) |
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize( | |
| "index_or_series_obj", [[1, 2, 3], ["a", "b", "c"], [0, "a", 1, "b", 2, "c"]] | |
| ) | |
| @pytest.mark.parametrize("sort", [True, False]) |
This overrides the original fixtures being used here
|
|
||
| for idx in [index1, index2]: | ||
| for lvl in range(idx.nlevels): | ||
| if has_mixed_types(idx.get_level_values(lvl)): |
Comment on lines
+939
to
+942
| pytest.skip( | ||
| f"Mixed types in MultiIndex level {lvl} are not orderable" | ||
| ) |
There was a problem hiding this comment.
Please add an xfail marker instead
92e9e10 to
a1eed56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.