signature: Add Signature operation for RSA #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tgonzalezorlandoarm merged 3 commits into main from tg/signature-sign

Apr 16, 2024

Member

tgonzalezorlandoarm commented Apr 11, 2024 •

edited

Loading

RSA sign test is now passing

Depends on #42

tgonzalezorlandoarm requested a review from gowthamsk-arm

April 11, 2024 15:40

tgonzalezorlandoarm self-assigned this

tgonzalezorlandoarm force-pushed the tg/signature-sign branch 2 times, most recently from 40d0d6c to df89469 Compare

April 12, 2024 10:29

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider/src/keymgmt/mod.rs Outdated Show resolved Hide resolved

tgonzalezorlandoarm force-pushed the tg/signature-sign branch 2 times, most recently from 58e803b to 765b474 Compare

April 12, 2024 15:23

tgonzalezorlandoarm added the enhancement label

tgonzalezorlandoarm mentioned this pull request

signature: Add Signature Context Duplication capabilities #24

Closed

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider/src/signature/mod.rs Show resolved Hide resolved

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider/src/signature/mod.rs Outdated Show resolved Hide resolved

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider/src/signature/mod.rs Outdated Show resolved Hide resolved

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider/src/signature/mod.rs Outdated Show resolved Hide resolved

tgonzalezorlandoarm force-pushed the tg/signature-sign branch 3 times, most recently from 6d70f8d to 14c2b26 Compare

April 15, 2024 16:04

Collaborator

gowthamsk-arm commented Apr 15, 2024

Can you add a test case for sig is NULL condition?

tgonzalezorlandoarm mentioned this pull request

signature: Enable ECDSA signing #44

Merged

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider/src/signature/mod.rs Show resolved Hide resolved


          signature: Add Signature operation

4791d4a

Implement:

 * OSSL_FUNC_SIGNATURE_SIGN

as indicated by
https://www.openssl.org/docs/man3.0/man7/provider-signature.html

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>

tgonzalezorlandoarm force-pushed the tg/signature-sign branch 2 times, most recently from bf5a9cb to 720c8b7 Compare

April 16, 2024 09:16

Member Author

tgonzalezorlandoarm commented Apr 16, 2024

Can you add a test case for sig is NULL condition?

Done

gowthamsk-arm reviewed

View reviewed changes

parsec-openssl-provider-shared/e2e_tests/tests/sign.rs Show resolved Hide resolved

tgonzalezorlandoarm added 2 commits

April 16, 2024 10:46


          e2e_tests: Add sign_verify test for when sig = NULL

d37b453

According to:

https://www.openssl.org/docs/man3.0/man7/provider-signature.html

"If sig is NULL then the maximum length of the signature should be
written to *siglen."

 * Add some checks to test this functionality

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>


          e2e_tests: Re-enable rsa signing test

9491a93

Test is now passing as sign() has been implemented for RSA

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>

tgonzalezorlandoarm force-pushed the tg/signature-sign branch from 720c8b7 to 9491a93 Compare

April 16, 2024 09:46

gowthamsk-arm approved these changes

View reviewed changes

Collaborator

gowthamsk-arm left a comment

LGTM. Thanks.

tgonzalezorlandoarm merged commit ccb3b81 into main

tgonzalezorlandoarm deleted the tg/signature-sign branch

April 16, 2024 09:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels