Skip to content

Configure handshake tests to use Parsec keys #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 15, 2024

Conversation

gowthamsk-arm
Copy link
Collaborator

The keyname set in the client structure is used to load the Parsec key for the handshake tests. The tests are currently going to fail
as the RSA-PSS support is still not added. This will be added in future PRs.

Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The keyname set in the client structure is used to load the Parsec
key for the handshake tests. The tests are currently going to fail
as the RSA-PSS support is still not added. This will be added in
future PRs.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
@gowthamsk-arm gowthamsk-arm force-pushed the gsk/handshake_parsec branch 2 times, most recently from d42a82f to 88bb09d Compare May 15, 2024 13:56
This function is not needed as only parsec keys are tested.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
@gowthamsk-arm gowthamsk-arm force-pushed the gsk/handshake_parsec branch from 88bb09d to 8bf6c07 Compare May 15, 2024 14:49
Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, rest LGTM

@gowthamsk-arm gowthamsk-arm force-pushed the gsk/handshake_parsec branch from ec16431 to c170acd Compare May 15, 2024 17:52
Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
@gowthamsk-arm
Copy link
Collaborator Author

Had cargo fmt errors. Pushed the changes now.

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 2fb177b into main May 15, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the gsk/handshake_parsec branch May 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants