-
Notifications
You must be signed in to change notification settings - Fork 1
Configure handshake tests to use Parsec keys #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2963723
to
d72c1e2
Compare
tgonzalezorlandoarm
requested changes
May 15, 2024
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
The keyname set in the client structure is used to load the Parsec key for the handshake tests. The tests are currently going to fail as the RSA-PSS support is still not added. This will be added in future PRs. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
d42a82f
to
88bb09d
Compare
This function is not needed as only parsec keys are tested. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
88bb09d
to
8bf6c07
Compare
tgonzalezorlandoarm
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, rest LGTM
ec16431
to
c170acd
Compare
tgonzalezorlandoarm
previously approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
c170acd
to
456f8c3
Compare
Had cargo fmt errors. Pushed the changes now. |
tgonzalezorlandoarm
approved these changes
May 15, 2024
tgonzalezorlandoarm
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyname set in the client structure is used to load the Parsec key for the handshake tests. The tests are currently going to fail
as the RSA-PSS support is still not added. This will be added in future PRs.
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com