Skip to content

Pelson multiaxes colorbar #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

efiring
Copy link

@efiring efiring commented Aug 11, 2012

I have updated your work to master; it would be nice to get it merged soon, rather than letting it go stale. Is axes_grid the big hold-up?

ddale and others added 30 commits December 1, 2011 15:28
include instructions for users of packaging systems (e.g. MacPorts).
hexbin_demo.py crashes with gtk backend
…ff" toward the end of the filename so files are more appropriately grouped when viewed in file managers and thumbnail tools (eg. gthumb)
….6. Continue to use histogram for earlier Numpy versions.
…ache the baseline images, since the test results are never the same twice given different dictionary orderings in the file.
… removes titles and ticks from a figure before comparison. Use this throughout to make more of the tests less dependent on text differences.
vbr and others added 24 commits July 31, 2012 18:31
Changed wx.NamedColor to wx.NamedColour for compatibility with wxpython 2.9.
Changed wx.NamedColor to wx.NamedColour for compatibility with wxpython 2.9.
Update examples/user_interfaces/wxcursor_demo.py
Update examples/user_interfaces/mathtext_wx.py
Update examples/user_interfaces/embedding_in_wx4.py
Update examples/user_interfaces/embedding_in_wx2.py
Move Python 3 import of reload() to the module that uses it
Fixed logformatting for non integer bases.


Filled contours now use more of the available colormap range than
previously.
This change should have no effect on any plot, but it avoids
warnings that can arise when an inf occurs under a mask.
Previously, although vmin, vmax could be specified manually
in a norm used to initialize a ContourSet, the values would
be used only if both were specified.  Now one can set either
or both of vmin, vmax in the norm, and they will take precedence
over the default.
This changeset also simplifies and clarifies the vmin, vmax
explanation and handling for pcolor and pcolormesh.
…ntour

Formerly, colorbar would not place ticks at contour levels outside the
vmin-vmax range, and would not add line contour marks at such levels.
…ib into pelson-multiaxes_colorbar

Conflicts:
	lib/matplotlib/colorbar.py
	lib/matplotlib/tests/test_colorbar.py

I also had to change some result_images because of the change in
contourf colormapping, and fix the default orientation code to
restore the "vertical" default.
@efiring
Copy link
Author

efiring commented Aug 11, 2012

Maybe this pull request is not the right approach; I was not expecting to see 212 commits! Based against master, my branch simply has your original pull request plus a few other changes to make it pass all tests.

@pelson
Copy link
Owner

pelson commented Aug 11, 2012

This PR is a little worrying. If its ok, I think I will rebase the branch instead.

@pelson pelson closed this Aug 11, 2012
@efiring
Copy link
Author

efiring commented Aug 11, 2012

Yes, that's fine, but I hope you will be able to take advantage of the changes I made; you should end up with the same net effect. I can provide the changes (just a few diffs and some revised images) in some other form if you like. Yes, the PR approach above was completely wrong; I should have realized that sooner.

pelson pushed a commit that referenced this pull request Sep 7, 2012
pelson pushed a commit that referenced this pull request Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.