Stackless execution of magic __call() and __callStatick() methods. #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dstogov
commented
Apr 9, 2015
- __call() and __callStatic() don't call execute_ex() recursively any more.
- Recursive calls trough __call() won't lead to crash because of stack overflow.
- We don't keep temporary call frames for "fake" functions (save VM stack).
- Now __call() almost 2 times faster
…defy-call * 'opcodefy-call' of github.com:laruence/php-src: Ready for PR Fixed static call Improve performance by using prealloated op_arrray Respect called_scope Support internal magical __call/__callStatic opcode-fy magical __callStatic Opcode-fy magical __call
* master: Fixed GOTO executor Fixed typo Changed ArrayIterator implementation using zend_hash_iterator_... API. Allowed modification of itterated ArrayObject using the same behavior as proposed in `Fix "foreach" behavior`. Removed "Array was modified outside object and internal position is no longer valid" hack.
…rom zend_objects_API to zend_object_handlers.
Generalize API to allow reuse EG(trampline) for other purposes.
…. Keep ZEND_ACC_CALL_VIA_HANDLER for compatibility.
|
|
||
| ZEND_ASSERT(!(fbc->common.fn_flags & ZEND_ACC_GENERATOR)); | ||
|
|
||
| EG(scope) = fbc->common.scope; |
There was a problem hiding this comment.
EG(scope) is already set properly by previously call to this function (trampoline op_array). we don't need set it again here...
There was a problem hiding this comment.
agree. This may be removed.
|
Merger into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.