RFC: Add the RoundingMode enum #14833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff3949 to
a8d1e94
Compare
a8d1e94 to
7b54dc6
Compare
nielsdos
reviewed
Jul 5, 2024
Girgias
reviewed
Jul 6, 2024
ext/bcmath/bcmath.c
Outdated
Comment on lines
719
to
725
| zend_argument_value_error(3, "must be a valid rounding mode (PHP_ROUND_*)"); | ||
| /* This is currently unreachable, but might become reachable when new modes are added. */ | ||
| zend_argument_value_error(3, " is a rounding mode that is not supported"); |
There was a problem hiding this comment.
I don't see how this can happen now? As the value should always be a correct mode from the enum object, turning this into an assertion seems more logical.
There was a problem hiding this comment.
Cannot happen now (as the comment indicates), but can happen if additional cases are added to the RoundingMode enum in the future that cannot (easily) be supported with BCMath or where the implementation forgets to adjust BCMath.
This error message is thus intended to fail safely rather than crashing or returning bogus values.
There was a problem hiding this comment.
I would rather have this be an assertion and have a test in BC Math that cycles through all the cases of the enum to be sure we don't miss any new ones introduced.
There was a problem hiding this comment.
I've added an additional test based on round_RoundingMode.phpt that goes through all the enum cases, but I've preserved the error message instead of replacing it by an assert. The RoundingMode enum is owned by ext/standard, not ext/bcmath, so to me defensive programming makes sense there.
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Girgias
approved these changes
Jul 7, 2024
SakiTakamachi
approved these changes
Jul 13, 2024
This one will make sure that bcround() is not forgotten when adding rounding modes.
|
Hello there, I bisected to find why Apparently, since this PR we have issue in Nix to build the Build log + failing testsIt looks like it cannot find the The issue has been discovered thanks to Find the last successful build at: https://github.com/loophp/php-src-nix/actions/runs/9925576082 |
|
@petk is this related to some recent build script changes? |
I'm not sure I understand... This PR? |
|
Bisected to this commit: 5905857 |
|
Ah, sorry, I didn't see the comment above. I'll check. |
|
@Girgias, @drupol, @TimWolla, I think this should be the issue (there is missing PHPAPI). Is this it? --- a/ext/standard/php_math_round_mode.h
+++ b/ext/standard/php_math_round_mode.h
@@ -52,4 +52,4 @@
extern PHPAPI zend_class_entry *rounding_mode_ce;
-int php_math_round_mode_from_enum(zend_object *mode);
+PHPAPI int php_math_round_mode_from_enum(zend_object *mode);Issue can be also reproduced like this: |
|
Let me patch and retry. |
|
Yes, that fixed the issue immediately. I created the PR. Let me know if it's OK. |
nielsdos
pushed a commit
that referenced
this pull request
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum