Skip to content

fix: add missing PHPAPI #15142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2024
Merged

fix: add missing PHPAPI #15142

merged 1 commit into from
Jul 28, 2024

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 28, 2024 •
edited
Loading

Issue introduced in commit 5905857 from PR #14833

See more context at #14833 (comment)

@drupol drupol requested a review from bukka as a code owner July 28, 2024 17:37
petk
petk approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixes the ./configure --enable-bcmath=shared build. Thanks.

nielsdos
nielsdos requested changes Jul 28, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPAPI should be added to the C file too.

@drupol
fix: add missing PHPAPI
b2d8306 
Issue introduced in commit 5905857 from PR #14833
nielsdos
nielsdos approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, waiting for CI.

@drupol
Copy link
Contributor Author

drupol commented Jul 28, 2024

OK ! Sadly, if the previous PR has been merged without detecting the issue I reported, it will unlikely detect if this is fixing it.

@nielsdos
Copy link
Member

OK ! Sadly, if the previous PR has been merged without detecting the issue I reported, it will unlikely detect if this is fixing it.

That is true, but I'm not risking the introduction of new warnings, although very unlikely. It's more of a protocol basically to wait for CI.

@petk
Copy link
Member

petk commented Jul 28, 2024

I think there should be one day also CI build with using shared extensions and some of those phpized. That would detect this sooner.

@nielsdos
Copy link
Member

I think there should be one day also CI build with using shared extensions and some of those phpized. That would detect this sooner.

Probably, see also #13771

@nielsdos nielsdos merged commit 664c1d1 into php:master Jul 28, 2024
10 of 11 checks passed
@nielsdos
Copy link
Member

Merged, thanks!

@drupol drupol deleted the fix-missing-phpapi branch July 28, 2024 18:43
@drupol
Copy link
Contributor Author

drupol commented Jul 29, 2024

Builds are all successful now! https://github.com/loophp/php-src-nix/actions/runs/10136552760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petk petk petk approved these changes

@nielsdos nielsdos nielsdos approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drupol @nielsdos @petk