[RFC] Allow #[\Deprecated] on traits
#19045
Conversation
|
Is this waiting for #18817? |
|
Yes, I was planning to have #18817 merged first |
b5c39e5 to
40eeb18
Compare
Zend/tests/attributes/constants/constant_listed_as_target-internal.phpt
Outdated
Show resolved
Hide resolved
| @@ -2006,6 +2006,27 @@ ZEND_API ZEND_COLD void ZEND_FASTCALL zend_deprecated_constant(const zend_consta | |||
| zend_string_release(message_suffix); | |||
| } | |||
|
|
|||
| ZEND_API ZEND_COLD void zend_use_of_deprecated_trait( | |||
| zend_class_entry *trait, | |||
There was a problem hiding this comment.
| zend_class_entry *trait, | |
| const zend_class_entry *trait, |
There was a problem hiding this comment.
Can't do that without more widespread changes, trait gets passed to get_deprecation_suffix_from_attribute() which does not const its parameter, because it gets passed to zend_get_attribute_object() where the parameter isn't const, etc.
There was a problem hiding this comment.
I see, the rabbit hole goes deep. We should constify the scope down the change as a follow-up / sibling PR then, similarly to #19156 which was found during clone-with.
There was a problem hiding this comment.
I'm just having a look, and this rabbit hole goes very deep, as it requires adding const qualifiers for various AST functions.
|
Note: I've seen the new review request, but am currently busy. I'll try to get to that early next week at the latest. |
Zend/tests/attributes/deprecated/traits/conflicts_render_unused.phpt
Outdated
Show resolved
Hide resolved
Important points are resolved. Soft-LGTM.
fa138aa to
d9cc42f
Compare
https://wiki.php.net/rfc/deprecated_traits