[RFC] Allow #[\Deprecated] on traits
#19045
Conversation
|
Is this waiting for #18817? |
|
Yes, I was planning to have #18817 merged first |
b5c39e5 to
40eeb18
Compare
Zend/tests/attributes/constants/constant_listed_as_target-internal.phpt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Calling this test 001.phpt would be consistent with the other folders. The title line could also be unified.
There was a problem hiding this comment.
I'd prefer a more informative name - here this is just a test for the basic functionality, i.e. "basic" is appropriate
There was a problem hiding this comment.
Please keep naming and title in sync.
There was a problem hiding this comment.
The naming is a short version of the title - what would you suggest the naming be instead?
| @@ -2006,6 +2006,27 @@ ZEND_API ZEND_COLD void ZEND_FASTCALL zend_deprecated_constant(const zend_consta | |||
| zend_string_release(message_suffix); | |||
| } | |||
|
|
|||
| ZEND_API ZEND_COLD void zend_use_of_deprecated_trait( | |||
| zend_class_entry *trait, | |||
There was a problem hiding this comment.
| zend_class_entry *trait, | |
| const zend_class_entry *trait, |
There was a problem hiding this comment.
Can't do that without more widespread changes, trait gets passed to get_deprecation_suffix_from_attribute() which does not const its parameter, because it gets passed to zend_get_attribute_object() where the parameter isn't const, etc.
|
Note: I've seen the new review request, but am currently busy. I'll try to get to that early next week at the latest. |
https://wiki.php.net/rfc/deprecated_traits