Deprecate using null as an array offset and when calling array_key_exists()
#19511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
b1629ed to
6b521a3
Compare
TimWolla
reviewed
Aug 19, 2025
472c3c6 to
baeda1f
Compare
DanielEScherzer
requested changes
Aug 20, 2025
baeda1f to
a6d44e0
Compare
d5fd9e5 to
a602268
Compare
|
Still a few tests to fix but we're getting closer |
6f50c89 to
e508fcc
Compare
8f22921 to
dc5049b
Compare
arnaud-lb
reviewed
Aug 21, 2025
c47e2b5 to
58878be
Compare
2175fc1 to
636861f
Compare
636861f to
34132a7
Compare
|
JIT really is something. But PR is now passing tests |
nielsdos
requested changes
Aug 21, 2025
There was a problem hiding this comment.
I hate the extra state protections we have to do but I think we can simplify some of them.
This is why I don't like these kinds of deprecations, lots of pointless crap needs to be added to protect the engine. (Granted, this is not your fault, this is caused by a design problem of error handlers)
| @@ -500,6 +500,31 @@ static void ZEND_FASTCALL zend_jit_fetch_dim_r_helper(zend_array *ht, zval *dim, | |||
| } | |||
| ZEND_FALLTHROUGH; | |||
| case IS_NULL: | |||
| /* The array may be destroyed while throwing the notice. | |||
There was a problem hiding this comment.
Please, no.
I would prefer if you just fetched the result first, copied it to the return value zval, and then emitted the deprecation. Similarly in many other places (this won't be possible for all code because some return a zval* to the array slot).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19468
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists
cc @Girgias